ChipView for crossref and groups #6228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tooltip on crossref field. Improve display of groups.
|
Fixes #6140 |
Some css fixing ChipView field.
|
Should i continue this issuea? |
|
Sorry for the late reply. Everyone is a bit busy with life right now. I pushed a small change that hopefully fixes the indent issue. If there are still a few display problems, I would suggest you finish the feature first and then we have a look at them in the final steps. Also, if there are problems with the chipview (e.g. the indent), then it would be good to report them at https://github.com/jfoenixadmin/JFoenix. |
tobiasdiez
changed the title
@tobiasdiez can u help me a bit and check what about it coz i dont have idea whats wrong. |
koppor
changed the title
|
@dextep did you already had some time to investigate this issue further? |
|
@tobiasdiez yes ofc :) |
|
What's the status here? |
calixtus
added
status: stale
status: waiting-for-feedback
…ew-jfoenix-implementation � Conflicts: � .idea/runConfigurations/JabRef_Main.xml � src/main/java/org/jabref/gui/autocompleter/AutoCompleteSuggestionProvider.java � src/main/java/org/jabref/gui/autocompleter/SuggestionProvider.java � src/main/java/org/jabref/gui/fieldeditors/FieldNameLabel.java � src/main/java/org/jabref/gui/fieldeditors/LinkedEntriesEditor.java
tobiasdiez
added
status: ready-for-review
|
Thanks @dextep for your good work. I've now continued working on it and finished this PR. The UI is not perfect, but since it's already an improvement over the existing solution this is now ready for review. |
calixtus
approved these changes
Sep 1, 2020
Siedlerchr
added a commit
that referenced
this pull request
Sep 2, 2020
…torShutdown * upstream/master: Add connection check to NetworkTab in preferences (#6838) Refine IntelliJ howto to enable built-in compiler again (#6794) GitBook: [master] one page modified GitBook: [master] 3 pages and 3 assets modified Add missing } Refactor of remaining preference tabs to PreferencesService (#6836) ChipView for crossref and groups (#6228) Ignore codecov.io at external link check Fix linting issues Add "m-mauersberger" Update journalList.mv
Siedlerchr
added a commit
that referenced
this pull request
Sep 2, 2020
* upstream/master: Add connection check to NetworkTab in preferences (#6838) Refine IntelliJ howto to enable built-in compiler again (#6794) GitBook: [master] one page modified GitBook: [master] 3 pages and 3 assets modified Add missing } Refactor of remaining preference tabs to PreferencesService (#6836) ChipView for crossref and groups (#6228) Ignore codecov.io at external link check Fix linting issues Add "m-mauersberger" Update journalList.mv
1 task
koppor
pushed a commit
that referenced
this pull request
Nov 15, 2022
7a10e3f Bluebook: Remove small-caps for case short & legislation (#6305) ca4a92b Merge pull request #6244 from POBrien333/patch-1107 12743ad Create social-science-history.csl (#6233) f7c1d57 Update american-chemical-society.csl (#6231) aca6b23 ready: Update oil-shale.csl (#6225) aadae55 Create pallas.csl (#6204) cc7d016 Merge pull request #6253 from nschneid/patch-1 77fab39 Merge pull request #6282 from POBrien333/patch-1119 e2668eb Merge pull request #6263 from POBrien333/patch-1113 7f3244d move style to dependent folder 8584993 Create development-growth-differentiation.csl (#6226) dfe71ff Create biotechnology-and-bioprocess-engineering.csl (#6227) 0d91742 Create sn-computer-science.csl (#6228) a0d09b4 Create mots.csl (#6205) 47665e5 Update review-of-international-studies.csl d573b8b Create computer-supported-cooperative-work.csl cebec0e ACL: check if edition is ordinal before printing the word "edition" 03a0a39 Re-indent CSL styles 3c64906 fix self link 479c061 fix small issues after visual inspection a356e72 Create gnosis-journal-of-gnostic-studies.csl git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 7a10e3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltip on crossref field.
Improve display of groups.
Closes #6140.