Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use github action to publish snap #6063

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Use github action to publish snap #6063

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fdfcfa
Use github action to publish snap
LyzardKing Mar 4, 2020
1a7a4df
Build snap only for master branch
koppor Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/deployment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,11 @@ jobs:
- name: Build snap (1) Setup snapcraft
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to run this in parallel as it's own job?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently does not work at all: https://github.com/JabRef/jabref/actions/runs/49715346

cannot read snap file "build/distribution/jabref*.snap"

Trying to debug.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also very difficult to do it in parallel in a separate workflow (which is not what you meant, right?). IMHO it depends on the steps above (including jpackage, ...). Thus, we would need to duplicate 100 SLOC of the build file.

We could work with different jobs in the same build file. Then, we would need to introduce uploading the build directory (more?) to GitHub as data passing between jobs can only be done that way. This is not comfortable (we have to be sure that we don't forget something)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot read is because the * is not expanded. Fixed it in cd70746

uses: jhenstridge/snapcraft-build-action@v1
id: snapcraft
if: matrix.displayName == 'linux'
if: matrix.displayName == 'linux' && github.ref == 'refs/heads/master'
- name: Build snap (2) Run build
run: |
mv ${{ steps.snapcraft.outputs.snap }} build/distribution/
if: matrix.displayName == 'linux'
if: matrix.displayName == 'linux' && github.ref == 'refs/heads/master'
- name: Build snap (3) Upload snap
uses: jhenstridge/snapcraft-publish-action@v1
with:
Expand Down