Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored subtile changes to optics of library properties #5969

Merged
merged 3 commits into from
Feb 20, 2020

Conversation

calixtus
Copy link
Member

fixes #5604
Some subtile changes (added a scrollpane) to the library properties dialog (and to SaveOrderConfigDisplay and to FieldFormatterCleanupsPanel). FieldFormatterCleanupsPanel needs to be refactored in the future to mvvm-pattern, but this PR is just a quick fix for the issue, so the library properties are somewhat usable on scaled displays.

librarypropsup
librarypropsdown

@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 20, 2020
@koppor koppor merged commit 59ac5dd into JabRef:master Feb 20, 2020
@calixtus calixtus deleted the library_properties_optics branch February 22, 2020 13:49
Siedlerchr added a commit that referenced this pull request Mar 6, 2020
* upstream/master: (21 commits)
  Update module description (#5999)
  New Crowdin translations (#5990)
  Fix NPE in OpenAccessDoi (#5994)
  Move generate BibTeX keys to Edit menu (#5987)
  Fixed display of groups and links column in MainTable (#5985)
  Fixed loosing group if the most bottom one in list is dragged on itself (#5983)
  Dividers (#5975)
  Add initial section on code quality (#5991)
  Create .sonarcloud.properties
  Add new IntelliJ video tutorial to docs. (#5984)
  Fix checkstyle
  Optimize stream() code
  Use application/x-bibtex for Grobid instance
  New Crowdin translations (#5971)
  Set BibEntry to "changed" state before setting a new entry type (#5966)
  Rework tools menu (#5979)
  Help menu (#5976)
  Fixed formatting
  Refactored subtile changes to optics of library properties (#5969)
  Change grobid URL to jabref subdomain (#5972)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oversized Libray properties dialog
3 participants