duplicate query parameter removed

[MhhhxX]

Calling the Springer web search always throws an exception:

java.lang.NullPointerException
	at org.jabref.merged.module/kong.unirest.json.JSONObject.<init>(Unknown Source)
	at org.jabref.merged.module/kong.unirest.json.JSONObject.<init>(Unknown Source)
	at org.jabref/org.jabref.logic.importer.fetcher.SpringerFetcher.lambda$getParser$2(Unknown Source)
	at org.jabref/org.jabref.logic.importer.SearchBasedParserFetcher.performSearch(Unknown Source)
	at org.jabref/org.jabref.gui.importer.fetcher.WebSearchPaneViewModel.lambda$search$1(Unknown Source)
	at org.jabref/org.jabref.gui.util.BackgroundTask$1.call(Unknown Source)
	at org.jabref/org.jabref.gui.util.DefaultTaskExecutor$1.call(Unknown Source)
	at org.jabref.merged.module/javafx.concurrent.Task$TaskCallable.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)

In the SpringerFetcher class I saw that the ?q= parameter is added twice to the request url.
Once here

jabref/src/main/java/org/jabref/logic/importer/fetcher/SpringerFetcher.java

Line 40 in a140fca

private static final String API_URL = "http://api.springernature.com/meta/v1/json?q=";

and the second time in this line:

jabref/src/main/java/org/jabref/logic/importer/fetcher/SpringerFetcher.java

Line 159 in a140fca

uriBuilder.addParameter("q", query); // Search query

This PR removes the duplicate search query parameter from the springer api url.

• Change in CHANGELOG.md described (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for bigger UI changes)
• Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

[Siedlerchr]

Thanks for your contribution 👍 , fix looks good to me, I will test it locally (as the fetcher tests for srpinger aren't executed on github)

[tobiasdiez]

Thanks for your contribution and the detail PR description! The change looks good to me.

[Siedlerchr]

Thanks, tested it and it works fine!

[MhhhxX]

You're welcome :)