Fix database tests and enable running using GitHub workflows #5676

koppor · 2019-11-26T23:27:34Z

fix behavior when no entries have to be inserted during a synch
fix database tests
have dbms test test only one database
DBMS to test is passed via environment variable "DBMS", defaulting to PostgreSQL
add shared information on Canonical BibTeX entry
some code improvement
have checkstyle running on github workflows (not on Travis)

src/main/java/org/jabref/logic/shared/DBMSConnectionProperties.java

Siedlerchr · 2019-11-27T07:48:38Z

In general: Why do you run the database tests on github and not on travis?
Travis should be faster as it has better caching.

tobiasdiez

Cool! That looks really good.

I'm in favor of moving from travis to github. From what I've observed, the github servers are quicker than travis; and the integration here on github is better (you immediately see which jobs failed).

.github/workflows/checkstyle.yml

docs/testing.md

src/main/java/org/jabref/logic/shared/DBMSSynchronizer.java

src/main/java/org/jabref/model/database/shared/DBMSType.java

src/test/java/org/jabref/logic/shared/DBMSProcessorTest.java

src/test/java/org/jabref/logic/shared/DBMSSynchronizerTest.java

koppor · 2019-11-28T07:16:43Z

OK, i merged the jobs.

Result: Increase build time by approx 15 minutes, because the build upload takes 12 minutes:

Before:

After:

Siedlerchr · 2019-11-28T07:28:26Z

This is ridiculous. We always decoupled the build from the tests.

koppor · 2019-11-28T07:29:00Z

Time added via merged workflow: 16:15 min

Build upload: 11,47min
Build Download: 4,46min

Since workflows run in parallel (maybe even on different machines on Azure), the split workflows do add only the time required for "setup up job", which is 3s.

In all jobs, the source needs to be checked out (13s) and the JDK needs to be setup (8s)

koppor · 2019-11-28T07:29:27Z

GitHub workflow decouple the runtimes. Thus, it is understandable that transfer costs are high.

koppor · 2019-11-28T07:31:29Z

It also depends, where we want to decouple. Currently, we do it at the command line level. Meaning, we host a separate instance of the database system etc. The other possibility would be to spawn off different threads within one job and let gradle / bash do some paralellization. I dislike that option, because it is a very tight coupling and a working X11 server, PostgresDB should not be an issue for checkstyle or logic test.

koppor · 2019-11-28T07:32:25Z

(Just as reminder - we started 2015 with following test order)

Siedlerchr · 2019-11-28T07:32:48Z

Travis is much more efficient running tests in parallel because it can better reuse stuff

koppor · 2019-11-28T07:37:03Z

If we have different workflows, we also have more bubbles there.

Current state with one workflow:

In case more workflows are there, we get more bubbles:

koppor · 2019-11-28T07:40:18Z

Setting up the environment (databses) is very hard on travis. I spent many hours on this. With GitHub Workflow this was a matter of minutes for postgres and half an hour for MySQL. - I need to shut down services on travis because of memory usage. Needs much test tweaking.

Separate for workflows for different tests are IMHO not that hard to maintain.

…(future) parallel test execution

koppor · 2019-11-29T11:29:22Z

.github/workflows/check-outdated-dependencies.yml

-          ${{ runner.OS }}-gradle-
-          ${{ runner.OS }}-
-    - uses: actions/cache@v1
-      name: Cache gradle wrapper


Did the fetching from the gradle executable jar from the cache take longer than fetching from gradle? - I wanted to reduce the GET requests to the gradle server by caching the wrapper binaries with this task.

As this check is now run weekly, there is no need to optimize anything.

koppor · 2019-11-29T12:07:12Z

I don't know why the fetcher tests are not executed. They are compiled, but no tests are run. Locally, they do run.

tobiasdiez

ok, everything seems to work now.

koppor · 2019-11-29T15:53:42Z

LGTM now, I would merge and discuss the general things afterwards in the devcall.

12dbba5 Create tyndale-bulletin (#5673) b0746db Create Engineered Regeneration (#5682) e38b953 wikipedia citation template (#5662) 5e7f731 Create early-music-history.csl (#5679) 86443f3 Create zeitschrift-fur-politik.csl (#5676) 68f1996 Create annals-of-work-exposures-and-health.csl (#5666) 1ba9dc6 Create brazilian-journal-of-psychiatry.csl (#5672) 438f92c fix error for speech in ama styles (#5693) 7a0c2d3 set initialize-with-hyphen to false (#5689) 3bd2765 Update emu-austral-ornithology.csl (#5671) 31492b2 fix various errors in natura-croatica.csl (#5687) 94d6b23 Update iso690-author-date-cs.csl (#5677) 5d017da minor update on the "Haute école de gestion de Genève - ISO 690" style (#5665) 2cad8f6 add ibid/subsequent to comparative-politics.csl (#5669) de0b116 Create taylor-and-francis-vancouver-national-library-of-medicine.csl (#5650) ed87f99 Update bulletin-de-correspondance-hellenique.csl (#5663) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 12dbba5

0654e16 Create scandinavian-journal-of-information-systems.csl (#5716) ce2d537 Update journal-of-computer-applications-in-archaeology.csl (#5715) 755d3d3 Create human-rights-law-review.csl (#5626) 0feda94 Create journal-of-intercultural-studies.csl (#5709) ae4756d Update acta-universitatis-agriculturae-sueciae.csl (#5713) 323d9ac Update mohr-siebeck-recht.csl (#5559) 15530a8 Bch corr (#5712) 094a1af Create forschungsjournal-soziale-bewegungen-fjsb.csl (#5699) cb91566 initialize authors and editors (#5714) 2d5cfff Create cancer-biomarkers.csl (#5703) 5e264d5 Update multidisciplinary-digital-publishing-institute.csl (#5708) 46e961f Create klinische-padiatrie.csl (#5711) e81e877 Create bulletin-archeologique-des-ecoles-francaises-a-l-etranger.csl (#5704) 0029c5a Create polar-research.csl 🧊 (#5702) 7db1361 Update vancouver-imperial-college-london.csl (#5641) b953e9f Update iso690-author-date-fr-no-abstract.csl (#5706) 91eda8c Update thieme-german.csl (#5710) ebe0787 Update harvard-imperial-college-london.csl (#5643) 2d4db76 Fix UNESCO IIEP in text 436cbf4 Create revue-archeologique-de-narbonnaise.csl (#5688) 5150bcf Create journal-of-computer-assisted-tomography.csl (#5690) dd6f050 Create anti-trafficking-review.csl (#5658) 08e622f Create the-angle-orthodontist.csl (#5685) c6a1907 journal-of-palm-oil-research.csl fix several errors (#5686) 6cbe29d Create bern-university-of-applied-sciences-school-of-agricultural-for… (#5684) f590dc1 Update biomed-central.csl (#5701) 1efce81 Update turabian-author-date.csl (#5695) 12dbba5 Create tyndale-bulletin (#5673) b0746db Create Engineered Regeneration (#5682) e38b953 wikipedia citation template (#5662) 5e7f731 Create early-music-history.csl (#5679) 86443f3 Create zeitschrift-fur-politik.csl (#5676) 68f1996 Create annals-of-work-exposures-and-health.csl (#5666) 1ba9dc6 Create brazilian-journal-of-psychiatry.csl (#5672) 438f92c fix error for speech in ama styles (#5693) 7a0c2d3 set initialize-with-hyphen to false (#5689) 3bd2765 Update emu-austral-ornithology.csl (#5671) 31492b2 fix various errors in natura-croatica.csl (#5687) 94d6b23 Update iso690-author-date-cs.csl (#5677) 5d017da minor update on the "Haute école de gestion de Genève - ISO 690" style (#5665) 2cad8f6 add ibid/subsequent to comparative-politics.csl (#5669) de0b116 Create taylor-and-francis-vancouver-national-library-of-medicine.csl (#5650) ed87f99 Update bulletin-de-correspondance-hellenique.csl (#5663) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 0654e16

* Squashed 'buildres/csl/csl-styles/' changes from 3a6a0a7..0654e16 0654e16 Create scandinavian-journal-of-information-systems.csl (#5716) ce2d537 Update journal-of-computer-applications-in-archaeology.csl (#5715) 755d3d3 Create human-rights-law-review.csl (#5626) 0feda94 Create journal-of-intercultural-studies.csl (#5709) ae4756d Update acta-universitatis-agriculturae-sueciae.csl (#5713) 323d9ac Update mohr-siebeck-recht.csl (#5559) 15530a8 Bch corr (#5712) 094a1af Create forschungsjournal-soziale-bewegungen-fjsb.csl (#5699) cb91566 initialize authors and editors (#5714) 2d5cfff Create cancer-biomarkers.csl (#5703) 5e264d5 Update multidisciplinary-digital-publishing-institute.csl (#5708) 46e961f Create klinische-padiatrie.csl (#5711) e81e877 Create bulletin-archeologique-des-ecoles-francaises-a-l-etranger.csl (#5704) 0029c5a Create polar-research.csl 🧊 (#5702) 7db1361 Update vancouver-imperial-college-london.csl (#5641) b953e9f Update iso690-author-date-fr-no-abstract.csl (#5706) 91eda8c Update thieme-german.csl (#5710) ebe0787 Update harvard-imperial-college-london.csl (#5643) 2d4db76 Fix UNESCO IIEP in text 436cbf4 Create revue-archeologique-de-narbonnaise.csl (#5688) 5150bcf Create journal-of-computer-assisted-tomography.csl (#5690) dd6f050 Create anti-trafficking-review.csl (#5658) 08e622f Create the-angle-orthodontist.csl (#5685) c6a1907 journal-of-palm-oil-research.csl fix several errors (#5686) 6cbe29d Create bern-university-of-applied-sciences-school-of-agricultural-for… (#5684) f590dc1 Update biomed-central.csl (#5701) 1efce81 Update turabian-author-date.csl (#5695) 12dbba5 Create tyndale-bulletin (#5673) b0746db Create Engineered Regeneration (#5682) e38b953 wikipedia citation template (#5662) 5e7f731 Create early-music-history.csl (#5679) 86443f3 Create zeitschrift-fur-politik.csl (#5676) 68f1996 Create annals-of-work-exposures-and-health.csl (#5666) 1ba9dc6 Create brazilian-journal-of-psychiatry.csl (#5672) 438f92c fix error for speech in ama styles (#5693) 7a0c2d3 set initialize-with-hyphen to false (#5689) 3bd2765 Update emu-austral-ornithology.csl (#5671) 31492b2 fix various errors in natura-croatica.csl (#5687) 94d6b23 Update iso690-author-date-cs.csl (#5677) 5d017da minor update on the "Haute école de gestion de Genève - ISO 690" style (#5665) 2cad8f6 add ibid/subsequent to comparative-politics.csl (#5669) de0b116 Create taylor-and-francis-vancouver-national-library-of-medicine.csl (#5650) ed87f99 Update bulletin-de-correspondance-hellenique.csl (#5663) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 0654e16 * Squashed 'buildres/csl/csl-locales/' changes from 0cc3885f61..d5ee85de8e d5ee85de8e Period after Übers. added (#241) git-subtree-dir: buildres/csl/csl-locales git-subtree-split: d5ee85de8e74d4109509014758b6f496a968ff03 * fix merge error Co-authored-by: github actions <[email protected]> Co-authored-by: Siedlerchr <[email protected]>

3bb4b5f infoclio.ch styles for German: remove non-breaking space delimiters (#5754) adf28db Create journal-of-health-care-for-the-poor-and-underserved.csl (#5752) 0713a8e Update chinese-gb7714-2005-numeric.csl (#5737) 1cd3754 Update china-national-standard-gb-t-7714-2015-author-date.csl (#5746) c2536b7 Update china-national-standard-gb-t-7714-2015-numeric.csl (#5745) f8c1392 Create steel-research-international.csl (#5720) 21fe1f5 Create asian-myrmecology.csl (#5718) 91e9e2b Update harvard-university-of-the-west-of-england.csl (#5734) dd453d1 fix minor erros in polar-research.csl (#5730) 038a8f5 Remove group around no-date cluster (#5731) 0710b51 remove et-al from bibtex.csl (#5728) bbd703d Add editorial-director to universite-laval-departement-des-sciences-historiques.csl (#5727) 58ea430 Create german-journal-of-agricultural-economics.csl (#5717) 0654e16 Create scandinavian-journal-of-information-systems.csl (#5716) ce2d537 Update journal-of-computer-applications-in-archaeology.csl (#5715) 755d3d3 Create human-rights-law-review.csl (#5626) 0feda94 Create journal-of-intercultural-studies.csl (#5709) ae4756d Update acta-universitatis-agriculturae-sueciae.csl (#5713) 323d9ac Update mohr-siebeck-recht.csl (#5559) 15530a8 Bch corr (#5712) 094a1af Create forschungsjournal-soziale-bewegungen-fjsb.csl (#5699) cb91566 initialize authors and editors (#5714) 2d5cfff Create cancer-biomarkers.csl (#5703) 5e264d5 Update multidisciplinary-digital-publishing-institute.csl (#5708) 46e961f Create klinische-padiatrie.csl (#5711) e81e877 Create bulletin-archeologique-des-ecoles-francaises-a-l-etranger.csl (#5704) 0029c5a Create polar-research.csl 🧊 (#5702) 7db1361 Update vancouver-imperial-college-london.csl (#5641) b953e9f Update iso690-author-date-fr-no-abstract.csl (#5706) 91eda8c Update thieme-german.csl (#5710) ebe0787 Update harvard-imperial-college-london.csl (#5643) 2d4db76 Fix UNESCO IIEP in text 436cbf4 Create revue-archeologique-de-narbonnaise.csl (#5688) 5150bcf Create journal-of-computer-assisted-tomography.csl (#5690) dd6f050 Create anti-trafficking-review.csl (#5658) 08e622f Create the-angle-orthodontist.csl (#5685) c6a1907 journal-of-palm-oil-research.csl fix several errors (#5686) 6cbe29d Create bern-university-of-applied-sciences-school-of-agricultural-for… (#5684) f590dc1 Update biomed-central.csl (#5701) 1efce81 Update turabian-author-date.csl (#5695) 12dbba5 Create tyndale-bulletin (#5673) b0746db Create Engineered Regeneration (#5682) e38b953 wikipedia citation template (#5662) 5e7f731 Create early-music-history.csl (#5679) 86443f3 Create zeitschrift-fur-politik.csl (#5676) 68f1996 Create annals-of-work-exposures-and-health.csl (#5666) 1ba9dc6 Create brazilian-journal-of-psychiatry.csl (#5672) 438f92c fix error for speech in ama styles (#5693) 7a0c2d3 set initialize-with-hyphen to false (#5689) 3bd2765 Update emu-austral-ornithology.csl (#5671) 31492b2 fix various errors in natura-croatica.csl (#5687) 94d6b23 Update iso690-author-date-cs.csl (#5677) 5d017da minor update on the "Haute école de gestion de Genève - ISO 690" style (#5665) 2cad8f6 add ibid/subsequent to comparative-politics.csl (#5669) de0b116 Create taylor-and-francis-vancouver-national-library-of-medicine.csl (#5650) ed87f99 Update bulletin-de-correspondance-hellenique.csl (#5663) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 3bb4b5f

koppor force-pushed the migrate-database-tests-to-github branch 14 times, most recently from 61267b4 to 29a2c10 Compare November 27, 2019 05:56

koppor changed the title ~~[WIP] Fix datbase tests and enable running using GitHub workflows~~ Fix datbase tests and enable running using GitHub workflows Nov 27, 2019

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 27, 2019

koppor marked this pull request as ready for review November 27, 2019 06:02

Siedlerchr requested changes Nov 27, 2019

View reviewed changes

src/main/java/org/jabref/logic/shared/DBMSConnectionProperties.java Outdated Show resolved Hide resolved

tobiasdiez requested changes Nov 27, 2019

View reviewed changes

koppor force-pushed the migrate-database-tests-to-github branch from aa9b108 to 29a2c10 Compare November 28, 2019 07:35

koppor and others added 3 commits November 29, 2019 12:12

Switch test logger theme to a) mocha and b) mocha.parallel to enable …

b888f26

…(future) parallel test execution

Don't overoptimize (parallel) - just show skipped and failed tests

0cbbaee

Run outdated dependency check weekly

382fd97

koppor commented Nov 29, 2019

View reviewed changes

tobiasdiez and others added 6 commits November 29, 2019 12:31

Create outdatedDependencies.md

f30066e

Introduce TravisCI environment variable CI

0446759

Include checkstyle in main test workflow

ae2a0ab

Delete checkstyle.yml

99de01d

Fix ordering of jacoco call

02fe4fc

Try to find out why fetcher tests are not executed on GitHub workflows

a0021ed

tobiasdiez added 3 commits November 29, 2019 13:11

Split tests into seperate jobs to parallelize

11bb9b9

Make sure all tests are executed

26fe33e

Make mysql tests run

324f822

tobiasdiez approved these changes Nov 29, 2019

View reviewed changes

stefan-kolb added the status: devcall label Nov 29, 2019

Siedlerchr approved these changes Nov 29, 2019

View reviewed changes

koppor mentioned this pull request Nov 29, 2019

Release 5.0-beta #5684

Merged

koppor merged commit ea5e632 into master Nov 29, 2019

koppor deleted the migrate-database-tests-to-github branch November 29, 2019 15:58

koppor restored the migrate-database-tests-to-github branch November 29, 2019 16:25

koppor deleted the migrate-database-tests-to-github branch November 29, 2019 16:26

koppor mentioned this pull request Feb 2, 2020

MySQL: Allow public key retrieval #5909

Merged

koppor removed the status: devcall label Feb 26, 2020

koppor mentioned this pull request Jan 9, 2024

Streamline test output #10762

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix database tests and enable running using GitHub workflows #5676

Fix database tests and enable running using GitHub workflows #5676

koppor commented Nov 26, 2019 •

edited

Loading

Siedlerchr commented Nov 27, 2019

tobiasdiez left a comment •

edited

Loading

koppor commented Nov 28, 2019

Siedlerchr commented Nov 28, 2019

koppor commented Nov 28, 2019

koppor commented Nov 28, 2019

koppor commented Nov 28, 2019

koppor commented Nov 28, 2019

Siedlerchr commented Nov 28, 2019

koppor commented Nov 28, 2019

koppor commented Nov 28, 2019

koppor Nov 29, 2019

tobiasdiez Nov 29, 2019

koppor commented Nov 29, 2019

tobiasdiez left a comment

koppor commented Nov 29, 2019

Fix database tests and enable running using GitHub workflows #5676

Fix database tests and enable running using GitHub workflows #5676

Conversation

koppor commented Nov 26, 2019 • edited Loading

Siedlerchr commented Nov 27, 2019

tobiasdiez left a comment • edited Loading

Choose a reason for hiding this comment

koppor commented Nov 28, 2019

Siedlerchr commented Nov 28, 2019

koppor commented Nov 28, 2019

koppor commented Nov 28, 2019

koppor commented Nov 28, 2019

koppor commented Nov 28, 2019

Siedlerchr commented Nov 28, 2019

koppor commented Nov 28, 2019

koppor commented Nov 28, 2019

koppor Nov 29, 2019

Choose a reason for hiding this comment

tobiasdiez Nov 29, 2019

Choose a reason for hiding this comment

koppor commented Nov 29, 2019

tobiasdiez left a comment

Choose a reason for hiding this comment

koppor commented Nov 29, 2019

koppor commented Nov 26, 2019 •

edited

Loading

tobiasdiez left a comment •

edited

Loading