Fix exception when merging entries #5395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that `sourceChanged` was invoked asynchronous and thus the information in the change event could be obsolete if another thread changed the underlying list in the meantime. Solution: run `sourceChanged` on the JavaFX thread but synchronously. Fixes #5169.
tobiasdiez
added
the
status: ready-for-review
matthiasgeiger
approved these changes
Oct 6, 2019
koppor
reviewed
Oct 6, 2019
| public UiThreadList(ObservableList<? extends T> source) { | ||
| super(source); | ||
| } | ||
|
|
||
| @Override | ||
| protected void sourceChanged(ListChangeListener.Change<? extends T> change) { | ||
| Platform.runLater(() -> fireChange(change)); | ||
| if (Platform.isFxApplicationThread()) { |
There was a problem hiding this comment.
Oh, wow. This reads like an ugly hack. Good, that this works...
Would be nice if some comments were added:
- Why can it happen that this method is called inside and outside the FxApplication thread?
- Why can the
fireChangemethod be run directly in the case of inside the FxApplication? - Why is
CountDownLatchused and not something more different (it is used as Boolean flag)?
|
I merged to keep things moving. However, it would be nice if my code questions would lead no another PR adding comments on the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that
sourceChangedwas invoked asynchronous and thus the information in the change event could be obsolete if another thread changed the underlying list in the meantime. Solution: runsourceChangedon the JavaFX thread but synchronously.Fixes #5169.