Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eclipse javafx module access #5390

Merged
merged 3 commits into from
Oct 5, 2019
Merged

Fix eclipse javafx module access #5390

merged 3 commits into from
Oct 5, 2019

Conversation

Siedlerchr
Copy link
Member

I may need to add some tweaks as well

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@Siedlerchr Siedlerchr changed the title [WIP] Fix javafx module access Fix eclipse javafx module access Oct 5, 2019
@Siedlerchr Siedlerchr merged commit cb65af0 into master Oct 5, 2019
@Siedlerchr Siedlerchr deleted the fixEclipseModule branch October 5, 2019 16:44
Siedlerchr added a commit that referenced this pull request Oct 5, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into enableFetcherTEst
b75ad56 
* upstream/master:
  Fix eclipse javafx module access  (#5390)
  Add UUID for upgrading (#5391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Siedlerchr