Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Russian translation #5059

Merged
merged 1 commit into from
Jun 16, 2019
Merged

Fix Russian translation #5059

merged 1 commit into from
Jun 16, 2019

Conversation

burrbull
Copy link
Contributor

Should fix this bug when select Russian translation

java.lang.IllegalStateException: It is not allowed that the toReplace string: '<tt>author=smith and title=electrical</tt>' does not exist in the original string
	at org.jabref.gui.util.TooltipTextUtil.splitReplace(TooltipTextUtil.java:92)
	at org.jabref.gui.util.TooltipTextUtil.formatToTexts(TooltipTextUtil.java:62)
	at org.jabref.gui.search.GlobalSearchBar.setHintTooltip(GlobalSearchBar.java:291)
...

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

Should fix this bug when select Russian translation
```
java.lang.IllegalStateException: It is not allowed that the toReplace string: '<tt>author=smith and title=electrical</tt>' does not exist in the original string
	at org.jabref.gui.util.TooltipTextUtil.splitReplace(TooltipTextUtil.java:92)
	at org.jabref.gui.util.TooltipTextUtil.formatToTexts(TooltipTextUtil.java:62)
	at org.jabref.gui.search.GlobalSearchBar.setHintTooltip(GlobalSearchBar.java:291)
...
```
@Siedlerchr
Copy link
Member

Thanks for your contribution! For further translations you can use crowdin, https://crowdin.com/project/jabref
The translations are then automatically synced with the ones from github and you get suggestions from previous translations.

@burrbull
Copy link
Contributor Author

What I should do with this PR? Shall I move changes to crowdin or you'll make it yourself?

@Siedlerchr
Copy link
Member

Siedlerchr commented Jun 16, 2019

I merge this PR now, then I will trigger the sync with crowdin and then you can continue to do further updates there.

@Siedlerchr Siedlerchr merged commit f300a83 into JabRef:master Jun 16, 2019
@burrbull burrbull deleted the patch-1 branch June 16, 2019 09:47
@Siedlerchr
Copy link
Member

@burrbull If you start translating on crowding then please tell me your account name there, so I can add you as proofreader (you can then accept your own translations)

@burrbull
Copy link
Contributor Author

I've signed with github account: Zgarbul Andrey (@ burrbull)

@Siedlerchr
Copy link
Member

github-actions bot pushed a commit that referenced this pull request Nov 1, 2020
5c376b8 Create karlstad-universitet-kau-harvard-swedish.csl (#5083)
6a62c24 Create ucl-institute-of-education-harvard.csl (#5084)
4d1bbb0 Update ferdinand-porsche-fern-fachhochschule.csl (#5073)
3a9f494 Update cureus.csl (#5087)
181c0dd Create apa-no.csl (#5059)
651ce48 Some fixes for Advanced Functional Materials (#5080)
4e3297a Acta Zoologica Hungarica: Don't demote nd particles
c659df7 Create medicina-delle-dipendenze-italian-journal-of-the-addictions.csl (#5078)
d243055 Update geografia-fisica-e-dinamica-quaternaria.csl (#5079)
1ee3809 Update mcgill-en.csl (#5076)
949cdc6 Update mcgill-fr.csl (#5075)
ee7d4e1 Create chem-catalysis.csl (#5074)
ec9faec Switch Molecular Therapy to Cell (#5070)
cf6034c Switch Elsevier to their own ad-vancouver (#5072)
78cca13 Updates in research-institute-for-nature-and-forest.csl (#4958)
68b7478 Update journal-of-neolithic-archaeology.csl (#5065)
524ba93 Create offa.csl (#5066)
9713a82 Update associacao-brasileira-de-normas-tecnicas-ufrgs-note-initials-with-ibid (#5067)
44449df Uodate associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (#5061)
baf9efa Create İstanbul Üniversitesi Sosyal Bilimler Enstitüsü Ali Ekber Çına… (#5064)
c5c3531 Fix CORR
853a804 Major Update mcgill-fr.csl to 9th ed. (#5057)
d3e2cd9 Update mcgill-en.csl (#5056)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5c376b8
github-actions bot pushed a commit to dimitra-karadima/jabref that referenced this pull request Nov 15, 2020
55200d0 Create computational-intelligence.csl (JabRef#5102)
6d2efc3 Merge branch 'master' of github.com:citation-style-language/styles
60ab0fb Add Steinbeis SMI
d5e0130 Add AAQR Style
d964f9b Create bitonline-publikationen.csl (JabRef#5090)
0dc1a56 Add "APA 7th edition" to Norsk APA style titles (JabRef#5098)
3b6aaf7 Update norsk-apa-manual.csl (JabRef#5095)
0139c63 Create technische-universitat-dresden-betriebswirtschaftslehre-rechnungswesen-controlling.csl (JabRef#5034)
fdc4497 Update universidade-estadual-de-alagoas-abnt (JabRef#5085)
afdc2ea Create revista-espanola-de-nutricion-humana-y-dietetica.csl (JabRef#5082)
939189d Create citation-compass-apa-note-no.csl (JabRef#5060)
414f5e6  brazilian-journal-of-veterinary-research: add bib sorting (JabRef#5091)
dbae9d7 Add DOI to Thieme German
f4399aa APA: match="any" bugfixes (JabRef#5092)
d0cc2c4 Add APA numeric and update BioEssays (JabRef#5089)
5c376b8 Create karlstad-universitet-kau-harvard-swedish.csl (JabRef#5083)
6a62c24 Create ucl-institute-of-education-harvard.csl (JabRef#5084)
4d1bbb0 Update ferdinand-porsche-fern-fachhochschule.csl (JabRef#5073)
3a9f494 Update cureus.csl (JabRef#5087)
181c0dd Create apa-no.csl (JabRef#5059)
651ce48 Some fixes for Advanced Functional Materials (JabRef#5080)
4e3297a Acta Zoologica Hungarica: Don't demote nd particles
c659df7 Create medicina-delle-dipendenze-italian-journal-of-the-addictions.csl (JabRef#5078)
d243055 Update geografia-fisica-e-dinamica-quaternaria.csl (JabRef#5079)
1ee3809 Update mcgill-en.csl (JabRef#5076)
949cdc6 Update mcgill-fr.csl (JabRef#5075)
ee7d4e1 Create chem-catalysis.csl (JabRef#5074)
ec9faec Switch Molecular Therapy to Cell (JabRef#5070)
cf6034c Switch Elsevier to their own ad-vancouver (JabRef#5072)
78cca13 Updates in research-institute-for-nature-and-forest.csl (JabRef#4958)
68b7478 Update journal-of-neolithic-archaeology.csl (JabRef#5065)
524ba93 Create offa.csl (JabRef#5066)
9713a82 Update associacao-brasileira-de-normas-tecnicas-ufrgs-note-initials-with-ibid (JabRef#5067)
44449df Uodate associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#5061)
baf9efa Create İstanbul Üniversitesi Sosyal Bilimler Enstitüsü Ali Ekber Çına… (JabRef#5064)
c5c3531 Fix CORR
853a804 Major Update mcgill-fr.csl to 9th ed. (JabRef#5057)
d3e2cd9 Update mcgill-en.csl (JabRef#5056)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 55200d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants