-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add close all/others/... in Database Tab menu #491
Conversation
markActiveBasePanel(); | ||
} | ||
setWindowTitle(); | ||
updateEnabledState(); // FIXME: Man, this is what I call a bug that this is not called. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice FIXME. Any idea what this could mean here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I forgot what it meant 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is even fixed by calling this method and I added the FIXME because we must make sure that this is called every time we remove something, i don't know...
Changelog is missing. Otherwise 👍 |
@@ -2337,4 +2282,104 @@ private int showSaveDialog(String filename) { | |||
Localization.lang("Save before closing"), JOptionPane.YES_NO_CANCEL_OPTION, | |||
JOptionPane.WARNING_MESSAGE, null, options, options[2]); | |||
} | |||
|
|||
private void closeTab(BasePanel panel) { | |||
// TODO: this menu should be tab based not on the DragDropPopupPane |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about this TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be removed as this doesn't work with our current impl.
Add close all/others/... in Database Tab menu
See #314