Add close all/others/... in Database Tab menu #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-kolb
added
the
status: ready-for-review
| markActiveBasePanel(); | ||
| } | ||
| setWindowTitle(); | ||
| updateEnabledState(); // FIXME: Man, this is what I call a bug that this is not called. |
There was a problem hiding this comment.
Nice FIXME. Any idea what this could mean here?
There was a problem hiding this comment.
Nope, I forgot what it meant 😄
There was a problem hiding this comment.
Maybe it is even fixed by calling this method and I added the FIXME because we must make sure that this is called every time we remove something, i don't know...
|
Changelog is missing. Otherwise 👍 |
| @@ -2337,4 +2282,104 @@ private int showSaveDialog(String filename) { | |||
| Localization.lang("Save before closing"), JOptionPane.YES_NO_CANCEL_OPTION, | |||
| JOptionPane.WARNING_MESSAGE, null, options, options[2]); | |||
| } | |||
|
|
|||
| private void closeTab(BasePanel panel) { | |||
| // TODO: this menu should be tab based not on the DragDropPopupPane | |||
There was a problem hiding this comment.
Can be removed as this doesn't work with our current impl.
simonharrer
added a commit
that referenced
this pull request
Dec 9, 2015
Add close all/others/... in Database Tab menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #314