Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test #4518

Merged
merged 5 commits into from
Nov 29, 2018
Merged

Create test #4518

merged 5 commits into from
Nov 29, 2018

Conversation

Ali96kz
Copy link
Contributor

@Ali96kz Ali96kz commented Nov 27, 2018

refactor and create test for org.jabref.gui.exporter.SaveAllAction

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The changes look fine to me.

private JabRefFrame jabRefFrame = mock(JabRefFrame.class);
private DialogService dialogService = mock(DialogService.class);
private BibDatabaseContext bibDatabaseContext = mock(BibDatabaseContext.class);
private Optional<Path> databasePath = Optional.of(new File("C:\\Users\\John_Doe\\Jabref").toPath());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paths.get(...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 28, 2018
@Siedlerchr Siedlerchr merged commit 37be334 into JabRef:master Nov 29, 2018
Siedlerchr added a commit that referenced this pull request Dec 23, 2018
* upstream/master:
  Correct PNAS abbrev. (#4524)
  Create test (#4518)
  Bump junit-jupiter-params from 5.3.1 to 5.3.2 (#4514)
  Bump junit-vintage-engine from 5.3.1 to 5.3.2 (#4511)
  Bump junit-jupiter-engine from 5.3.1 to 5.3.2 (#4513)
  Bump richtextfx from 0.9.1 to 0.9.2 (#4512)
  Bump junit-jupiter-api from 5.3.1 to 5.3.2 (#4510)
  Bump junit-platform-launcher from 1.3.1 to 1.3.2 (#4515)
Siedlerchr added a commit that referenced this pull request Dec 28, 2018
* upstream/master: (49 commits)
  improve styling of preferences side menu (#4556)
  Cleanup interfaces (#4553)
  Bump fontbox from 2.0.12 to 2.0.13 (#4552)
  Bump pdfbox from 2.0.12 to 2.0.13 (#4551)
  Bump wiremock from 2.19.0 to 2.20.0 (#4550)
  Fixes that renaming a group did not change the group name in the interface (#4549)
  Bump applicationinsights-logging-log4j2 from 2.2.1 to 2.3.0 (#4540)
  Bump antlr4-runtime from 4.7.1 to 4.7.2 (#4542)
  Bump applicationinsights-core from 2.2.1 to 2.3.0 (#4541)
  Bump antlr4 from 4.7.1 to 4.7.2 (#4543)
  Fix journal name "Astronomy Journal" to "Astronomical Journal"
  fix-for-issue-4489 (#4538)
  Sorting of read-status isn't working as expected #4521 (#4536)
  Add preselect last used export format in export to clipboard dialog (#4533)
  fixed 4365 put html in clipboard (#4519)
  [WIP] Convert Exporter Customization Dialog to javafx (#4394)
  Fixes #4437 (#4531)
  Bump checkstyle from 8.14 to 8.15 (#4528)
  Correct PNAS abbrev. (#4524)
  Create test (#4518)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants