Make global font size customizable #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
Siedlerchr
requested changes
Jul 8, 2018
| int newFontSize = Integer.parseInt(fontSize.getText()); | ||
| prefs.putInt(JabRefPreferences.MAIN_FONT_SIZE, newFontSize); | ||
| isRestartRequired |= oldOverrideDefaultFontSize != overrideFonts.isSelected(); | ||
| isRestartRequired |= oldFontSize != newFontSize; | ||
|
|
There was a problem hiding this comment.
Is this a binary or? This one looks confusing
There was a problem hiding this comment.
yes, it is (bit-wise) or paired with assignment (similar to +=). See https://stackoverflow.com/questions/14295469/what-does-mean-pipe-equal-operator
There was a problem hiding this comment.
Can you please find another abstraction for solving this functionality? I know it's elegant, but I would not consider this as appropriate Java code within JabRef.
There was a problem hiding this comment.
Agree with Linus here, it's not intuitive and easy to read.
LinusDietz
requested changes
Jul 10, 2018
| int newFontSize = Integer.parseInt(fontSize.getText()); | ||
| prefs.putInt(JabRefPreferences.MAIN_FONT_SIZE, newFontSize); | ||
| isRestartRequired |= oldOverrideDefaultFontSize != overrideFonts.isSelected(); | ||
| isRestartRequired |= oldFontSize != newFontSize; | ||
|
|
There was a problem hiding this comment.
Can you please find another abstraction for solving this functionality? I know it's elegant, but I would not consider this as appropriate Java code within JabRef.
1 task
Siedlerchr
added a commit
that referenced
this pull request
Jul 26, 2018
* upstream/master: (47 commits) Make attached files relative to the file directory (#4212) execute set visible in swing thread to avoid blocking Fix isbn chimbori test (#4234) Rewrite web search pane in JavaFX (#4203) Update dependencies (#4231) Update to latest release of richtextfx (#4213) Fix fetcher tests (#4216) single line text fields (#4138) Make it easier to rename and move files (#4200) Fix that swing dialogs are hidden behind main window (#4205) Fixed: #4166 add move & rename file (#4217) update gradle plugins and gradlen to 4.9 Update dependencies Remove unnecessary look and feel migration (#4204) Revert threading fix since this sometimes lead to freezes... Update year Fix a few more threading exceptions Refactor Convert CiteSeerX fetcher to new infrastructure (#4185) Make global font size customizable (#4178) ... # Conflicts: # src/main/java/org/jabref/gui/BasePanel.java # src/main/java/org/jabref/gui/JabRefFrame.java # src/main/java/org/jabref/gui/mergeentries/MergeEntries.java # src/main/resources/l10n/JabRef_en.properties
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Font size customization was removed in #4109 since it didn't work properly (i.e. only some elements of the ui were scaled). With this PR the global font size can be controlled by the user (in the Appearance tab of the preference dialog) and changes there affect every JavaFX control.