Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchange Ignore by Disabled #3912

Merged
merged 1 commit into from
Mar 31, 2018
Merged

Exchange Ignore by Disabled #3912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 15 additions & 19 deletions src/test/java/org/jabref/gui/importer/fetcher/OAI2HandlerFetcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
import org.jabref.model.entry.BibEntry;
import org.jabref.testutils.category.FetcherTest;

import org.junit.Ignore;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.xml.sax.SAXException;

Expand All @@ -23,9 +23,7 @@
/**
* Test for OAI2-Handler and Fetcher.
*
* @author Ulrich Stärk
* @author Christian Kopf
* @author Christopher Oezbek
* FIXME: Move this AND the OAI2HandlerFetcher to org.jabref.logic. Needs to be rewritten to new interface
*/

@FetcherTest
Expand Down Expand Up @@ -123,23 +121,21 @@ public void testFixKey() {
}

@Test
@Ignore
public void testOnline() throws InterruptedException, IOException, SAXException {

{
OAI2Fetcher fetcher = new OAI2Fetcher();
be = fetcher.importOai2Entry("math.RA/0612188");
assertNotNull(be);

assertEquals(Optional.of("math/0612188"), be.getField("eprint"));
assertEquals(Optional.of("On the classification and properties of noncommutative duplicates"),
be.getField("title"));
assertEquals(Optional.of("Javier López Peña and Gabriel Navarro"), be.getField("author"));
assertEquals(Optional.of("2007"), be.getField("year"));
public void testMathRA0612188() throws Exception {
OAI2Fetcher fetcher = new OAI2Fetcher();
be = fetcher.importOai2Entry("math.RA/0612188");
assertNotNull(be);

Thread.sleep(20000);
}
assertEquals(Optional.of("math/0612188"), be.getField("eprint"));
assertEquals(Optional.of("On the classification and properties of noncommutative duplicates"),
be.getField("title"));
assertEquals(Optional.of("Javier López Peña and Gabriel Navarro"), be.getField("author"));
assertEquals(Optional.of("2"), be.getField("year"));
}

@Test
@Disabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not fix the test instead disabling it?

public void testOnline() throws InterruptedException, IOException, SAXException {
{
OAI2Fetcher fetcher = new OAI2Fetcher();
be = fetcher.importOai2Entry("astro-ph/0702080");
Expand Down