Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required mock to LinkedfileViewModelTest #3909

Merged
merged 1 commit into from
Apr 1, 2018
Merged

Add required mock to LinkedfileViewModelTest #3909

merged 1 commit into from
Apr 1, 2018

Conversation

koppor
Copy link
Member

@koppor koppor commented Mar 31, 2018

While working on #3704, test were failing in other settings. This is a quick fix to get the tests running.

@koppor koppor mentioned this pull request Mar 31, 2018
Closed
8 tasks
tobiasdiez
tobiasdiez requested changes Mar 31, 2018
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do a proper refactoring and remove the Globals.prefs dependency from LinkedFileViewModel.

@Siedlerchr
Copy link
Member

I think for this build it's okay, in maintable-beta we already have it refactored

@koppor
Copy link
Member Author

koppor commented Apr 1, 2018

@Siedlerchr I hope, there won't be conflicts for the maintable-beta branch then. 😇

@koppor koppor merged commit 7bd7eda into master Apr 1, 2018
@koppor koppor deleted the add-mock branch April 1, 2018 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koppor @Siedlerchr @tobiasdiez