Add new authors to mailMap #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusDietz
added
type: documentation
status: waiting-for-feedback
Siedlerchr
reviewed
Dec 22, 2017
| Domenico Cufalo <[email protected]> | ||
| Tobias Bouschen <[email protected]> | ||
| József Pallagi <[email protected]> |
There was a problem hiding this comment.
Now new line at eof? is this correct?
There was a problem hiding this comment.
yes? Is there any reason against this?
koppor
requested changes
Dec 22, 2017
.mailmap
Outdated
| @@ -90,9 +90,9 @@ Ulrik Stervbo <[email protected]> | |||
| Stefano Gariazzo <[email protected]> | |||
| Lee Patton <[email protected]> | |||
| Jörg Lenhard <[email protected]> | |||
| <[email protected]> <[email protected]> | |||
There was a problem hiding this comment.
Please do not change this to the real name.
The intention is to map all different email addresses of one user to a single email address. The reason for that is that tools might have name + email or even the email only as unique key for code analysis. When having different emails, users might be treated as separate users.
There was a problem hiding this comment.
okay, the problem is just, that now if I run the generate-authors script a new name Joerg Lenhard appears. How can I do that properly?
|
Then add the Name in front additionally:
name mail mail
Am 22.12.2017 19:19 schrieb "Linus Dietz" <[email protected]>:
… ***@***.**** commented on this pull request.
------------------------------
In .mailmap
<#3567 (comment)>:
> @@ -90,9 +90,9 @@ Ulrik Stervbo ***@***.***>
Stefano Gariazzo ***@***.***>
Lee Patton ***@***.***>
Jörg Lenhard ***@***.***>
***@***.***> ***@***.***>
okay, the problem is just, that now if I run the generate-authors script
a new name Joerg Lenhard appears. How can I do that properly?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3567 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABTafo_s2PD9MlRNuOLJQD0FDKTDDXQoks5tC_KcgaJpZM4RK-_x>
.
|
LinusDietz
removed
the
status: waiting-for-feedback
Siedlerchr
added a commit
that referenced
this pull request
Dec 28, 2017
* upstream/master: (121 commits) Fix fetcher tests (#3583) Convert entry preview panel to JavaFX (#3574) Remove dependency for JUnit4 (#3580) Update tracis cache config as recommned by the docs (#3575) fix typo Show development information Release v4.1 Add new authors to mailMap (#3567) Fix build Really fix changelog Fix changelog Minor changes Disable the autocompletion as default (#3569) Add update exception for applicationinsights 2.0.0-BETA (#3571) Install4j jres 152 (#3570) Fix grammar mistake Downgrade applicationinsights. Fixes #3561 Adapt scripts/prepare-install4j.sh to JRE1.8.0_152 (#3568) ExportFormats: Use FileExtension enum (#3565) Update guava from 23.5-jre -> 23.6-jre ... # Conflicts: # build.gradle
Siedlerchr
added a commit
that referenced
this pull request
Dec 29, 2017
* upstream/master: (234 commits) Fix checkstyle Fix tests Fix fetcher tests (#3583) Convert entry preview panel to JavaFX (#3574) Remove dependency for JUnit4 (#3580) Update tracis cache config as recommned by the docs (#3575) fix typo Show development information Release v4.1 Add new authors to mailMap (#3567) Fix build Really fix changelog Fix changelog Minor changes Disable the autocompletion as default (#3569) Add update exception for applicationinsights 2.0.0-BETA (#3571) Install4j jres 152 (#3570) Fix grammar mistake Downgrade applicationinsights. Fixes #3561 Adapt scripts/prepare-install4j.sh to JRE1.8.0_152 (#3568) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the new authors of Jabref. 🎉
I have contacted @MBunel and @weidafan, whether they can provide us their full names, so let's wait until the release before we merge this.