Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adsurl to url #2861

Merged
merged 3 commits into from
May 24, 2017
Merged

Adsurl to url #2861

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3dbf38
move adsurl field to url field when fetching with ADS fetcher.
jhshinn May 23, 2017
e57367f
Update CHANGELOG.md
jhshinn May 23, 2017
c7d73e4
Update AstrophysicsDataSystem.java
jhshinn May 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
## [Unreleased]

### Changed
- We moved the `adsurl` field to `url` field when fetching with the ADS fetcher.
- We continued to improve the new groups interface:
- You can now again select multiple groups (and a few related settings were added to the preferences) [#2786](https://github.com/JabRef/jabref/issues/2786).
- We further improved performance of group operations, especially of the new filter feature [#2852](https://github.com/JabRef/jabref/issues/2852).
Expand Down
6 changes: 4 additions & 2 deletions src/main/java/org/jabref/logic/importer/fetcher/AstrophysicsDataSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import java.util.List;
import java.util.Objects;

import org.jabref.logic.cleanup.MoveFieldCleanup;
import org.jabref.logic.formatter.bibtexfields.ClearFormatter;
import org.jabref.logic.formatter.bibtexfields.NormalizeNamesFormatter;
import org.jabref.logic.formatter.bibtexfields.RemoveBracesFormatter;
Expand Down Expand Up @@ -154,8 +155,9 @@ public void doPostCleanup(BibEntry entry) {
new FieldFormatterCleanup(FieldName.TITLE, new RemoveBracesFormatter()).cleanup(entry);
new FieldFormatterCleanup(FieldName.AUTHOR, new NormalizeNamesFormatter()).cleanup(entry);

// Remove url to ADS page
// Remove ADS note
new FieldFormatterCleanup("adsnote", new ClearFormatter()).cleanup(entry);
new FieldFormatterCleanup("adsurl", new ClearFormatter()).cleanup(entry);
// Move adsurl to url field
new MoveFieldCleanup("adsurl","url").cleanup(entry);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use FieldName.URL instead of "url". Moreover, add a space after the comma.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasdiez I've revised the file as you commented. Thanks for your comment-

}
}