Fix lucene query #12100
Fix lucene query #12100
Conversation
Field names shouldn't contain any special characters; otherwise, the parser will throw an exception.
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
| public static Query searchToLucene(SearchQuery searchQuery) { | ||
| public static String searchToLucene(SearchQuery searchQuery) { |
There was a problem hiding this comment.
We loos strong typing, but I think, the conversion is easier now.
There was a problem hiding this comment.
Yes, because using the Analyzer here removes words like "a" and "the", which can lead to empty queries with null. This also made testing a bit confusing. For example, if the search term was image, I had to know its stem (imag) for the tests to pass.
| public String getUniqueName() { | ||
| if (getDatabasePath().isPresent()) { | ||
| Path databasePath = getDatabasePath().get(); | ||
| return BackupFileUtil.getUniqueFilePrefix(databasePath) + "--" + databasePath.getFileName(); | ||
| } | ||
| return "unsaved" + NUMBER_OF_UNSAVED_LIBRARIES++; | ||
| } | ||
|
|
There was a problem hiding this comment.
That this is removed explains a lot - I missed "my" numbers at untitled - but it is OK IMHO.
The other unique path feature still works:
Refs https://github.com/JabRef/jabref-issue-melting-pot/issues/614
There was a problem hiding this comment.
No, this method was used only for the Postgres table name, so it is another issue.
Follow-up to #11803
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/652
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/655
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)