Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Identifier paste work with Unicode REPLACEMENT CHARACTER #12083

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MadDingzhen
Copy link

Slightly change to DOI method so it can now replace all so it won't bothering when import doi with
Also added some data in org.jabref.model.entry.identifier.DOITest#testData

Closes #11986

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Copy link
Member

koppor commented Oct 25, 2024

Please fix checkstyle. See box of GitHub at pull request - or run checkstyle in your IDE

@koppor
Copy link
Member

koppor commented Oct 25, 2024

Please learn about

git fetch upstream
git merge upstream/main

for the next pull request; this gets updates in. No need for a strange commit ...

@MadDingzhen
Copy link
Author

MadDingzhen commented Oct 25, 2024 via email

@calixtus
Copy link
Member

Please change the title of this pr. Nobody knows without clicking around what issue no 11986 is. Every other pr has a reasonable name.

@MadDingzhen MadDingzhen changed the title Solved Issue#11986 Solved Issue#11986 "Identifier paste should work with Unicode REPLACEMENT CHARACTER" Oct 25, 2024
@MadDingzhen
Copy link
Author

Please change the title of this pr. Nobody knows without clicking around what issue no 11986 is. Every other pr has a reasonable name.

Nailed it.

@subhramit subhramit changed the title Solved Issue#11986 "Identifier paste should work with Unicode REPLACEMENT CHARACTER" Make Identifier paste work with Unicode REPLACEMENT CHARACTER Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identifier paste should work with Unicode REPLACEMENT CHARACTER
3 participants