Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CitationKey as a default column (#10510) #12080

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

suftware
Copy link
Contributor

Added CitationKey as a default column to the entry table by adding it to the default preferences. This closes #10510.

image

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the base issue and the premise, because even if our focus is bibtex, even the heavy bibtex users dont need this column all the time and introducing it is just 4 clicks away.

But.

Decisions have been made and the change looks good to me. So I approve. Thank you.

@koppor koppor added this pull request to the merge queue Oct 25, 2024
Merged via the queue into JabRef:main with commit ad491f1 Oct 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-introduce CitationKey column as default in the entry (main) table
3 participants