Illegal character in query: pipe character in file field #11876 #12062
Conversation
Modified the handling of URLs in the file field to replace the pipe character (|) with its encoded representation (%7C) to avoid exceptions in JabRef. Closes JabRef#123
Modified the handling of URLs in the file field to replace the pipe character (|) with its encoded representation (%7C) to avoid exceptions in JabRef. Closes JabRef#11876
|
Please add some tests for this as well! |
There was a problem hiding this comment.
Please follow the advice at #11876 (comment)
The current issue is NOT a fix. The URL is a valid one and can be opened in a browser.
Also add tests.
koppor
added
the
status: changes required
|
Thanks for the feedback. Following the steps in your comment #11876 (comment), should I implement the escape function in the URLUtil class and then replace all calls to URI.create throughout the project with the new function I created, centralizing the escaping process? |
Yes |
This pull request implements URL escaping for the pipe character (|) in the FileFieldParser class. This change addresses issue #11876, which caused exceptions in JabRef when processing URLs that contained the pipe character.
Changes Made: Modified the FileFieldParser class to replace the pipe character with its encoded representation (%7C).
Ensured that URLs are properly handled to prevent exceptions.
Benefits: Resolves the recurring exception issue when opening .bib files with problematic URLs.
Related Issue: Closes #11876