Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show only one notification when cutting an entry #11724

Merged
merged 7 commits into from
Sep 8, 2024
Merged

Show only one notification when cutting an entry #11724

merged 7 commits into from
Sep 8, 2024

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Sep 7, 2024 •
edited
Loading

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/198

Pulls importHandler out of MainTable into LibraryTab

before
image

after
grafik

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 7, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@calixtus calixtus changed the title Move cut and copy out of MainTable into LibraryTab Show only one notification when cutting an entry Sep 7, 2024
@koppor koppor added this pull request to the merge queue Sep 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 8, 2024
@koppor koppor added the jabcon label Sep 8, 2024
@koppor koppor added this pull request to the merge queue Sep 8, 2024
Merged via the queue into main with commit 17b7697 Sep 8, 2024
26 of 27 checks passed
@koppor koppor deleted the fix-double-notification branch September 8, 2024 11:47
leaf-soba pushed a commit to leaf-soba/jabref that referenced this pull request Sep 11, 2024
@calixtus
Show only one notification when cutting an entry (JabRef#11724)
1389b14 
* Move cut and copy out of MainTable into LibraryTab

* Move ImportHandler to LibraryTab and Reword methods

* Seperated notifications

* l10n

* CHANGELOG.md

* Wording consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
jabcon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calixtus @koppor