Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make path relative after BibTeX-from-PDF import #11576

Merged
merged 16 commits into from
Aug 6, 2024
Merged

Make path relative after BibTeX-from-PDF import #11576

merged 16 commits into from
Aug 6, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Aug 4, 2024

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor changed the title Refine JavaDoc for PdfMergeMetadataImporter Make path relative after BibTeX-from-PDF import Aug 4, 2024
set.add(new SemanticScholar(importerPreferences));
set.add(new ResearchGate(importFormatPreferences));

// Uses the PDFs - adn then uses the parsed Dpi. Makes it 10% a web fetcher.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos

@@ -38,8 +38,7 @@ public StandardFileType getFileType() {

@Override
public String getDescription() {
return "Imports a Biblioscape Tag File.\n" +
"Several Biblioscape field types are ignored. Others are only included in the BibTeX field \"comment\".";
return "Imports a Biblioscape Tag File.\nSeveral Biblioscape field types are ignored. Others are only included in the BibTeX field \"comment\".";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L10n?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Some" localizations added: efd80e0

- We fixed an issue that online and offline mode for new library creation were handled incorrectly. [#11565](https://github.com/JabRef/jabref/pull/11565)
- We fixed an issue with colors in the search bar when dark theme is enabled. [#11569](https://github.com/JabRef/jabref/issues/11569)
- We fixed an issue where a new unsaved library was not marked with an asterisk. [#11519](https://github.com/JabRef/jabref/pull/11519)
- We fixed an issue where JabRef starts without window decorations. [#11440](https://github.com/JabRef/jabref/pull/11440)

### Removed


- We removed support for importing using the SilverPlatterImporter (`Record INSPEC`). [#11576](https://github.com/JabRef/jabref/pull/11576)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not want the translators to translate something 🤣🤣

Historical note: Tests were added at #510 - and

@koppor koppor enabled auto-merge August 6, 2024 20:23
Siedlerchr
Siedlerchr previously approved these changes Aug 6, 2024
@koppor koppor added this pull request to the merge queue Aug 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 6, 2024
@Siedlerchr Siedlerchr added this pull request to the merge queue Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit 372e5bd Aug 6, 2024
22 checks passed
@Siedlerchr Siedlerchr deleted the fix-11409 branch August 6, 2024 21:07
@koppor koppor mentioned this pull request Oct 16, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When creating an entry based on a PDF, the file path should be relative
2 participants