-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add value selection(like for month) for custom fields #11162
Conversation
CHANGELOG.md
Outdated
@@ -11,6 +11,9 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv | |||
|
|||
### Added | |||
|
|||
- We added a new keyboard shortcut <kbd>ctrl</kbd> + <kbd>,</kbd> to open the preferences. [#11154](https://github.com/JabRef/jabref/pull/11154) | |||
- [azatayamanaev](https://github.com/azatyamanaev) added value selection(like for month) for content selectors in custom entry types. [#11109](https://github.com/JabRef/jabref/issues/11109) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not include our names here. Names are already part of the commit and committers will be highlighted at the release blog posts
@@ -112,7 +114,8 @@ private static SuggestionProvider<?> getSuggestionProvider(Field field, Suggesti | |||
// Enrich auto completion by content selector values | |||
try { | |||
return new ContentSelectorSuggestionProvider((SuggestionProvider<String>) suggestionProvider, contentSelectorValues); | |||
} catch (ClassCastException exception) { | |||
} catch ( | |||
ClassCastException exception) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unfortuantely an intellih formatting bug, please move this back to the previous line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azatyamanaev Do you use IntelliJ 2024.1 or something of 2023?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I use 2024.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Closes #11109
Added editor class for custom fields. This allows to select values from specified content selectors for corresponding field in entry editor tab.
When you add a custom field and set content selectors for it, in entry editor tab you can choose from a list of specified values.
Add a custom field
Set content selectors
Check value selection in entry editor tab
When the added custom field is multiline, standard text area field is used.
Change added custom field to multiline
Check how it is displayed in entry editor tab
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)