Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Key bindings" to "Keyboard shortcuts" #11153

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Change "Key bindings" to "Keyboard shortcuts" #11153

merged 4 commits into from
Apr 5, 2024

Conversation

jeanprbt
Copy link
Contributor

@jeanprbt jeanprbt commented Apr 5, 2024

This PR updates the Preferences tab for Key bindings, renaming it to Keyboard shortcuts. It updates the tab title, the page title and the messages when changing keyboard shortcuts. This follows a request from @koppor on the Gitter channel.
This PR updates the file in resources/l10n/JabRef_en.properties to replace all occurrences of key\ bindings with keyboard\ shortcuts.

Capture d’écran 2024-04-05 à 16 35 11

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Copy link
Member

koppor commented Apr 5, 2024

The "key binding" should not appear in the language file any more. If it does, you missed some string. (Or adapt the PR description)

Reason: We do not keep unused strings.

@jeanprbt
Copy link
Contributor Author

jeanprbt commented Apr 5, 2024

Sorry about that, I updated the PR description. All occurrences of "key bindings" are in fact replaced by "keyboard shortcuts".

@Siedlerchr
Copy link
Member

Changelog entry please under "changed" section

CHANGELOG.md Outdated Show resolved Hide resolved
@Siedlerchr Siedlerchr added this pull request to the merge queue Apr 5, 2024
Merged via the queue into JabRef:main with commit 74c8917 Apr 5, 2024
20 checks passed
@jeanprbt jeanprbt deleted the change-bindings-to-shortcuts branch April 5, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants