Add tooltip for bib entries in Main Table #10997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tooltip that shows on all rows in maintable - Add function that creates bibPreview information (only author and year so far)
- The tablerows are now receiving data models to display tooltip
- Not connected to actual tooltip yet Closes #4
- Should verify the behaviour of the checkboxes in the preferences menu - Tests are not currently working for unknown reason
- tooltip can be controlled by the checkbox in preference settings
- Static BooleanProperty should be defined first in the BibEntryTableViewModel class
- Add tests that check functionality of methods that work with datamodel for tooltip
Co-Authored-By: AlexWidman <[email protected]> Co-Authored-By: kihlert <[email protected]>
Siedlerchr
reviewed
Mar 9, 2024
| this.bibPreview = createBibPreviewTooltip(entry); | ||
| } | ||
|
|
||
| private String createBibPreviewTooltip(BibEntry entry) { |
There was a problem hiding this comment.
This is the wrong appraoch. As stated in the issuse you should use the existing methods for generating previews
See how it's done in the PrevieViewer
|
Closing this PR due to inactivity 💤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Tooltip on maintable cell which shows full table cell content. A checkbox in PreviewTab is added to toggle on/off this functionality.
The checkbox "show preview in entry table tooltip"as required by the issue is put in JabRef-preferences/Entry-Preview.
When checkbox is toggled off, only tooltip on column cells are shown.
When checkbox is toggled on, tooltip on the whole bibentry is shown.
Closes Tooltip on main table cell should show full table cell content #10925
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)