Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JUnit5BestPractices #10797

Closed
wants to merge 1 commit into from
Closed

Add JUnit5BestPractices #10797

wants to merge 1 commit into from

Conversation

koppor
Copy link
Member

@koppor koppor commented Jan 15, 2024

This rewrites all JUnit5 test cases to best practices:

  • RemoveTestPrefix
  • TestsShouldNotBePublic

Also add already applied recipes to rewrite.yml

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Also add already applied recipes
Copy link
Contributor

github-actions bot commented Jan 15, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor
Copy link
Member Author

koppor commented Jan 15, 2024

OMG...

@Siedlerchr
Copy link
Member

ALLES KAPUTTTT!!!!!°

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants