Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parent field to Hayagriva YAML export #10633

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

JawadTUE
Copy link
Contributor

Closes #10596

The parent field is added to the Hayagriva YAML exporter, which was introduced in #10451

Previously, the exporter neglected some fields, addressing two specific cases:

  1. Case 1 (entry type: article):
    • The journal field is now included under the parent field in addition to volume, issue, and publisher (if present).
  2. Case 2 (entry type: book):
    • The series field is now included under the parent field.
    • The issue and publisher are also added for books

I confirmed that the exported .yaml file works with the typst system by using hayagriva literature.yaml reference as stated in their documentation.

Also, I compared the exports of the typst system with the exports from jabref and they contained the same fields.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

CHANGELOG.md Outdated Show resolved Hide resolved
Siedlerchr
Siedlerchr previously approved these changes Nov 14, 2023
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 14, 2023
Co-authored-by: Christoph <[email protected]>
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Siedlerchr Siedlerchr added this pull request to the merge queue Nov 14, 2023
Merged via the queue into JabRef:main with commit c75506f Nov 14, 2023
17 checks passed
Siedlerchr added a commit to xuanan20020/jabref that referenced this pull request Nov 21, 2023
* upstream/main: (24 commits)
  Clean up test code (JabRef#10658)
  Bump org.openrewrite.rewrite from 6.4.0 to 6.5.4 (JabRef#10650)
  Bump com.puppycrawl.tools:checkstyle from 10.12.4 to 10.12.5 (JabRef#10654)
  Bump com.fasterxml.jackson.dataformat:jackson-dataformat-yaml (JabRef#10653)
  Bump com.github.Dansoftowner:jSystemThemeDetector from 3.6 to 3.8
  Remove comments - don't work on forks
  Update journal abbreviation lists (JabRef#10645)
  Use clparse (instead of heylogs) (JabRef#10641)
  Update CSL styles (JabRef#10642)
  Added parent field to Hayagriva YAML export (JabRef#10633)
  Bump org.fxmisc.richtext:richtextfx from 0.11.1 to 0.11.2 (JabRef#10637)
  Bump io.github.classgraph:classgraph from 4.8.163 to 4.8.164 (JabRef#10634)
  Bump org.junit.platform:junit-platform-launcher from 1.10.0 to 1.10.1 (JabRef#10635)
  Bump org.mockito:mockito-core from 5.6.0 to 5.7.0 (JabRef#10638)
  Bump com.tngtech.archunit:archunit-junit5-engine from 1.1.0 to 1.2.0 (JabRef#10636)
  add some more spaces
  Fix CHANGELOG.md
  Remove SearchListener
  Refactor method name to reflect usage
  Revert "Remove filtering on query in maintable"
  ...
Siedlerchr added a commit that referenced this pull request Nov 26, 2023
* upstream/main:
  Update journal abbreviation lists (#10645)
  Use clparse (instead of heylogs) (#10641)
  Update CSL styles (#10642)
  Added parent field to Hayagriva YAML export (#10633)
  Bump org.fxmisc.richtext:richtextfx from 0.11.1 to 0.11.2 (#10637)
  Bump io.github.classgraph:classgraph from 4.8.163 to 4.8.164 (#10634)
  Bump org.junit.platform:junit-platform-launcher from 1.10.0 to 1.10.1 (#10635)
  Bump org.mockito:mockito-core from 5.6.0 to 5.7.0 (#10638)
  Bump com.tngtech.archunit:archunit-junit5-engine from 1.1.0 to 1.2.0 (#10636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some fields are dropped when exporting to Hayagriva
2 participants