Check if value is already a Short DOI #10612

michalfarago · 2023-11-01T19:35:15Z

Closes #10589

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

- Introduced predicate to check if the value is already a short DOI - UTest

Siedlerchr

lgtm
please add a changelog entry

src/main/java/org/jabref/logic/formatter/bibtexfields/ShortenDOIFormatter.java

- Added entry to CHANGELOG - Modified the regex pattern

ShortDoi

ce2bf6e

- Introduced predicate to check if the value is already a short DOI - UTest

Siedlerchr previously approved these changes Nov 1, 2023

View reviewed changes

k3KAW8Pnf7mkmdSMPHz27 reviewed Nov 1, 2023

View reviewed changes

src/main/java/org/jabref/logic/formatter/bibtexfields/ShortenDOIFormatter.java Outdated Show resolved Hide resolved

Changelog

fbf5369

- Added entry to CHANGELOG - Modified the regex pattern

michalfarago dismissed Siedlerchr’s stale review via fbf5369 November 2, 2023 07:32

Merge branch 'JabRef:main' into ShortDOI-check

62e3361

michalfarago marked this pull request as ready for review November 2, 2023 07:54

Siedlerchr approved these changes Nov 2, 2023

View reviewed changes

Siedlerchr added this pull request to the merge queue Nov 2, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 2, 2023

Siedlerchr merged commit edc2cb2 into JabRef:main Nov 2, 2023
17 checks passed

Provide feedback