-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for PR 9717 #10599
Closed
Closed
Fix for PR 9717 #10599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor getResolvedFieldOrAlias for clarity and modern style - Use Stream API for better readability and concise code. - Simplify the logic to fetch the first resolved field or alias. - No change in the method's functionality or output.
…references to the current entry and update the relevant cells. 2. Added the addFileFromCrossref(LinkedFile file) method to add files from cross-referenced entries and update the file list. 3. Modified the removeCrossref() method to ensure that the relevant cells are updated when removing cross-references. 4. Added the updateCitationKey(String newCitationKey) method to update the citation key of cross-referenced entries and update the relevant cells. 5. Added the removeCrossrefedEntry(BibEntry crossrefedEntry) method to remove cross-referenced entries and update the relevant cells. 6. Added the updateCell() method to update the data in the cells. The specific implementation should be tailored to your code structure and requirements. 7. Added the updateFiles(List<LinkedFile> linkedFiles) method to update the file list. The specific implementation should be tailored to your code structure and requirements.
…references to the current entry and update the relevant cells. 2. Added the addFileFromCrossref(LinkedFile file) method to add files from cross-referenced entries and update the file list. 3. Modified the removeCrossref() method to ensure that the relevant cells are updated when removing cross-references. 4. Added the updateCitationKey(String newCitationKey) method to update the citation key of cross-referenced entries and update the relevant cells. 5. Added the removeCrossrefedEntry(BibEntry crossrefedEntry) method to remove cross-referenced entries and update the relevant cells. 6. Added the updateCell() method to update the data in the cells. The specific implementation should be tailored to your code structure and requirements. 7. Added the updateFiles(List<LinkedFile> linkedFiles) method to update the file list. The specific implementation should be tailored to your code structure and requirements.
I am confused. You now have two pull-requests open to improve 9717? |
Hello @Toro520, what's the status here? Are you planning to continue on your PR? |
As this PR lacks implementation and is only a collection of ideas in comments, and also the original submitter won't answer, i'm closing this PR. Feel free to create a new PR, if you decide to continue. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7731
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)