Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit group separator to one single character in Prefs->Entry Keyword Separator #10543

Merged
merged 9 commits into from
Oct 22, 2023
Merged

Limit group separator to one single character in Prefs->Entry Keyword Separator #10543

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
886d363
Update information
koppor Oct 22, 2023
8569c81
Updated CHANGELOG.md to meet the markdown check.
colinldbd Oct 22, 2023
fe862da
Updated CHANGELOG.md to meet the markdown check.
colinldbd Oct 22, 2023
1748de2
Updated CHANGELOG.md to meet the markdown check.
colinldbd Oct 22, 2023
a74b6fc
Updated CHANGELOG.md to meet the markdown check.
colinldbd Oct 22, 2023
91dbb80
Update snapcraft.yaml
calixtus Oct 22, 2023
1e5af74
Update CHANGELOG.md
calixtus Oct 22, 2023
6c06d90
Update bug_report.yml
calixtus Oct 22, 2023
9271bf9
Update CHANGELOG.md
koppor Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ In case, there is no issue present, the pull request implementing the feature is

Note that this project **does not** adhere to [Semantic Versioning](https://semver.org/).

## [Unreleased]
## [Unreleased] – 2023-10-22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't worry about this, there is another fix for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't worry about this, there is another fix for this

Thanks for the reminder, I'm just worried why I can't pass the Markdown style check, but I guess for now it I don't need to do anything about it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to worry a bit. The issue is quite clear:

 10:1  error  Unexpected additional part: ' – 2023-10-22'  entry-for-every-versions

An unreleased version has no release date - but you added one ^^. Just remove it again.

Please also merge latest main, which improved the CHANGELOG.md check - #10537


### Added

### Changed - 2023-10-22
### Changed

- We changed the TextField for KeywordSeparator to only accepting 1 single character by using a TextFormatter in EntryTab.java so that Prefs dialog for groups should be adjusted that it is only possible to insert a single character as delimiter.[#177](https://github.com/koppor/jabref/issues/177)

Expand Down
Loading