Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fetcherName with Identifier-based Web Search #10391

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Replace fetcherName with Identifier-based Web Search #10391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
21e69c7
Replace fetcherName with Identifier-based Web Search
Luggas4you Sep 17, 2023
0eb73b0
Add l10n
Luggas4you Sep 21, 2023
4ff29c2
Merge branch 'main' into websearch-name
koppor Sep 21, 2023
b537931
Merge branch 'main' into websearch-name
koppor Sep 21, 2023
a50068d
Add Localization.lang(...)
koppor Sep 22, 2023
e3d48f4
Add CHANGELOG.md entry
koppor Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
### Changed

- The export formats `listrefs`, `tablerefs`, `tablerefsabsbib`, now use the ISO date format in the footer [#10383](https://github.com/JabRef/jabref/pull/10383).
- When searching for an identifier in the "Web search", the title of the search window is now "Identifier-based Web Search". [#10391](https://github.com/JabRef/jabref/pull/10391)

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public void search() {
if (CompositeIdFetcher.containsValidId(query)) {
CompositeIdFetcher compositeIdFetcher = new CompositeIdFetcher(preferencesService.getImportFormatPreferences());
parserResultCallable = () -> new ParserResult(OptionalUtil.toList(compositeIdFetcher.performSearchById(query)));
fetcherName = compositeIdFetcher.getName();
fetcherName = Localization.lang("Identifier-based Web Search");
}

final String finalFetcherName = fetcherName;
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/l10n/JabRef_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2596,3 +2596,4 @@ Show\ articles\ related\ by\ citation=Show articles related by citation
Error\ while\ fetching\ citing\ entries\:\ %0=Error while fetching citing entries: %0
Jump\ to\ entry\ in\ database=Jump to entry in database
Help\ on\ external\ applications=Help on external applications
Identifier-based\ Web\ Search=Identifier-based Web Search