Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devcontainer prebuilds #10333

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Fix devcontainer prebuilds #10333

merged 2 commits into from
Sep 6, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Sep 6, 2023

The pre-builds of our devcontainers failed. (They are configured at https://github.com/JabRef/jabref/settings/codespaces).

This PR fixes it with two ways:

  1. Introduces Foojay Toolchains Plugin to allow gradle download the JDK by itself (already it - see https://github.com/JabRef/jabref/actions/runs/6094889864)
  2. Install JDK20 in the container

Other improvements:

  • Always take latest debian release
  • Gradle should have a nicer output

Side note: I udpated the pre-build configuration to build once a week only. Should be enough (as currently no one seems to use that feature - we should nevertheless keep it as maintaining is less effort then re-introducing).

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

- Update JDK to be installed
- Always take latest debian release
- Gradle should have a nicer output
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor
Copy link
Member Author

koppor commented Sep 6, 2023

Codespaces build runs through: https://github.com/JabRef/jabref/actions/runs/6094968052

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 6, 2023
@koppor koppor merged commit 1dc08fc into main Sep 6, 2023
14 of 15 checks passed
@koppor koppor deleted the fix-prebuild branch September 6, 2023 12:13
Siedlerchr added a commit that referenced this pull request Sep 7, 2023
…nto fix-dependency-conflicts

* 'fix-dependency-conflicts' of github.com:JabRef/jabref:
  test updating javafx plugin but throws at runtime
  Revert "Add workaround for IDEA-317606 (#10322)"
  Add workaround for IDEA-317606 (#10322)
  New Crowdin updates (#10335)
  Add change in en.properties as well
  Correction of a typo in LinkedFileViewModel.java
  Fix devcontainer prebuilds (#10333)
  Add requires on org.freedesktop.dbus (#10332)
  Fix hint to menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants