Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check: opt-out + preferences #9742

Closed
koppor opened this issue Apr 5, 2023 · 8 comments · Fixed by #10064
Closed

Update check: opt-out + preferences #9742

koppor opened this issue Apr 5, 2023 · 8 comments · Fixed by #10064
Assignees
Milestone

Comments

@koppor
Copy link
Member

koppor commented Apr 5, 2023

Update check is currently always active. We need to

  • opt-in (similar to telemetry)
  • make it turn on/turn off in Preferences
@koppor koppor added this to the v5.10 milestone Apr 5, 2023
@Siedlerchr
Copy link
Member

We have a Do not ask again option

@koppor
Copy link
Member Author

koppor commented Apr 5, 2023

The first call needs to be opt-in. Otherwise, GitHub automatically receives the IP address. Otherwise, we would need to create a proxy not storing any data.

@tobiasdiez
Copy link
Member

You can also just call https://mango-pebble-0224c3803-dev.westeurope.1.azurestaticapps.net/api/getLatestRelease and github never gets the users IP. (We do, but will not save it or even look at it)

@koppor
Copy link
Member Author

koppor commented Apr 10, 2023

Quick solution: Do not do an automatic check. Just keep our button "Check for updates".

This has the risk that users will drop off in the long run, because they are not notified of new releases.

@tobiasdiez
Copy link
Member

I actually think the current situation with the "Do not ask again" option is sufficient. Do you remember the old dark times where we didn't had the update check and people opened issues for 5 years old versions? Yeah, don't wanna go back there

@koppor koppor changed the title Update check: opt-in + preferences Update check: opt-out + preferences May 8, 2023
@koppor
Copy link
Member Author

koppor commented May 8, 2023

@koppor
Copy link
Member Author

koppor commented Jul 11, 2024

You can also just call https://mango-pebble-0224c3803-dev.westeurope.1.azurestaticapps.net/api/getLatestRelease and github never gets the users IP. (We do, but will not save it or even look at it)

@tobiasdiez this is 404. Is there a more stable URL? api.jabref.org maybe?

@tobiasdiez
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants