Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save/save as: file type shows BIBTEX_DB #9372

Closed
2 tasks done
tobiasdiez opened this issue Nov 13, 2022 · 13 comments · Fixed by #9812
Closed
2 tasks done

Save/save as: file type shows BIBTEX_DB #9372

tobiasdiez opened this issue Nov 13, 2022 · 13 comments · Fixed by #9812
Assignees
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui

Comments

@tobiasdiez
Copy link
Member

JabRef version

5.7 (latest release)

Operating system

GNU / Linux

Details on version and operating system

No response

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Save a new file or use "save as" for an existing bib file
  2. The dialog shows then in the file type selector "BIBTEX_DB file". Instead it should show something like "Library (.bib file)"

Appendix

...

Log File
Paste an excerpt of your log file here
@tobiasdiez tobiasdiez added ui good first issue An issue intended for project-newcomers. Varies in difficulty. labels Nov 13, 2022
@ThiloteE
Copy link
Member

There is File > save library as ... > BIBTEX_DB file (*.bib)
There is also File > Export > Save selected as plain BibTeX... > BIBTEX_DB file (*.bib).

I propose to rename to BibTeX/BibLaTeX (*.bib) because this would be similar to how we show other file formats under

  • File > Export > Export all entries > ...
  • File > Export > Export selected entries > ...
  • File > Import > Import into current library > ...
  • File > Import > Import into new library > ...

As added bonus, it would spread the knowledge about BibLaTeX, which I think is a good thing because BibTeX is a little outdated and we not only support BibTeX, but also BibLaTeX.

Furthermore, I would propose to rename File > Export > Save selected as plain BibTeX... to File > Export > Save selected as plain BibTeX/BibLaTeX library file. Maybe remove the "plain"? Is there a difference between saving as BibTeX and exporting as BibTeX? Does exporting "plainly" remove some JabRef specific data from the file?

@ThiloteE
Copy link
Member

Removing good first issue, because we are still discussing

@ThiloteE ThiloteE removed the good first issue An issue intended for project-newcomers. Varies in difficulty. label Nov 18, 2022
@tobiasdiez
Copy link
Member Author

tobiasdiez commented Nov 18, 2022

Personally, I would strive to make JabRef's UI as independent as possible from the fact that we use Bib(La)TeX under the hood. JabRef's whole point is to abstract away the boring bibtex related things, so why should we remind people that they are still using it? This becomes especially relevant once we have our word addin running, which then hopefully attracts people that have never heard of bibtex before. After using Zotero and Mendeley for a bit, I really don't see anything that they do better then us - so I would like to position JabRef as "a wholesome reference manager that even works well with bibtex" over our current "a niche bibtex manager that is only useful for latex nerds".

So I would always use "Library file" over "BibTeX/BibLaTeX file". It is also shorter, which is nice for the menu.

@ThiloteE
Copy link
Member

ThiloteE commented Nov 18, 2022

so you propose to rename RIS (*.ris) also to library file (*.ris)?

@Siedlerchr
Copy link
Member

I agree with Thilo. And plain bibtex is bibtex without jabref metdata etc. Mods and RIS etc are also completely different formats. So we should use bibtex as it's the format.

@koppor
Copy link
Member

koppor commented Nov 18, 2022

I always position JabRef as tool for BibTeX. Some pro users hesitate to use JabRef if JabRef seems to move away from BibTeX.

Maybe, we need to offer two modes: Entry mode (which is a general mode avoiding BibTeX) and professional mode (which has more "BibTeX" in the UI and is more clear in BibTeX terms).

Maybe, it's "just" a new localization for the UI?

Maybe we should have a strategic call discussing the general direction.

@tobiasdiez
Copy link
Member Author

so you propose to rename RIS (*.ris) also to library file (*.ris)?

If we would use RIS as our main file format, yes. But its a nice Gedankenexperiment: would we put RIS everywhere in our UI if we would use it as our main file format?

@Siedlerchr Siedlerchr added type: enhancement good first issue An issue intended for project-newcomers. Varies in difficulty. labels Apr 1, 2023
@koppor
Copy link
Member

koppor commented Apr 1, 2023

My current vote is "BibTeX file" or "BibTeX library file". In all cases, not "DB" and no capital letters.

Context as picture

image

Note: We have "BIB file" in the preferences:

image

I personally would like ".bib file", but ".bib file (*.bib)" reads strange at the save dialog.

@morganteg
Copy link
Contributor

morganteg commented Apr 19, 2023

I'd like to work on this, please. I express my opinion, as well:
I'd prefer to have "BibTeX library (.bib)" or, in case of multiple supported extensions "BibTeXML (.bibx, .xml)".
This mainly because the user is quickly able to understand the file extension that is going to save. This should improve the UI usability.

@ThiloteE
Copy link
Member

Thanks for your continued engagement morgantex :-) Great job with pr 9703

@koppor
Copy link
Member

koppor commented Apr 21, 2023

We don't support BibTeXML any more. There should be no leftovers in the code hopefully...

@morganteg
Copy link
Contributor

We don't support BibTeXML any more. There should be no leftovers in the code hopefully...

I found it into the "main" branch. However, I used BibTeXML just as an example of Type with multiple extensions.

@calixtus
Copy link
Member

calixtus commented Apr 24, 2023

devcall decision:
It should show the DisplayName of BIBTEX_DB consistently throughout the gui.
grafik

/src/main/java/org/jabref/logic/util/StandardFileType.java#L21

I think the main issue is in:

public static FileChooser.ExtensionFilter toExtensionFilter(FileType fileType) {
String description = Localization.lang("%0 file", fileType.toString());
return new FileChooser.ExtensionFilter(description, fileType.getExtensionsWithAsteriskAndDot());

morganteg added a commit to morganteg/jabref that referenced this issue Apr 27, 2023
Change default File Chooser to show supported files extensions
morganteg added a commit to morganteg/jabref that referenced this issue Apr 28, 2023
Change default File Chooser to show supported files extensions
morganteg added a commit to morganteg/jabref that referenced this issue Apr 28, 2023
Change default File Chooser to show supported files extensions
morganteg added a commit to morganteg/jabref that referenced this issue Apr 28, 2023
Change default File Chooser to show supported files extensions
morganteg added a commit to morganteg/jabref that referenced this issue Apr 28, 2023
Change default File Chooser to show supported files extensions
Siedlerchr added a commit that referenced this issue Apr 28, 2023
* upstream/main: (31 commits)
  Fixes #9372 Change default File Chooser to show supported files extensions
  Fix path in devs documentation (#9810)
  New translations JabRef_en.properties (Tagalog)
  New translations JabRef_en.properties (Persian)
  New translations JabRef_en.properties (Indonesian)
  New translations JabRef_en.properties (Portuguese, Brazilian)
  New translations JabRef_en.properties (Vietnamese)
  New translations JabRef_en.properties (Chinese Traditional)
  New translations JabRef_en.properties (Chinese Simplified)
  New translations JabRef_en.properties (Ukrainian)
  New translations JabRef_en.properties (Turkish)
  New translations JabRef_en.properties (Swedish)
  New translations JabRef_en.properties (Russian)
  New translations JabRef_en.properties (Portuguese)
  New translations JabRef_en.properties (Polish)
  New translations JabRef_en.properties (Norwegian)
  New translations JabRef_en.properties (Dutch)
  New translations JabRef_en.properties (Korean)
  New translations JabRef_en.properties (Japanese)
  New translations JabRef_en.properties (Italian)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants