Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App hang on exit on macOS #9075

Closed
2 tasks done
iandol opened this issue Aug 20, 2022 · 2 comments · Fixed by #9076
Closed
2 tasks done

App hang on exit on macOS #9075

iandol opened this issue Aug 20, 2022 · 2 comments · Fixed by #9076
Labels
bug Confirmed bugs or reports that are very likely to be bugs openoffice/libreoffice

Comments

@iandol
Copy link

iandol commented Aug 20, 2022

JabRef version

Latest development branch build (please note build date below)

Operating system

macOS

Details on version and operating system

JabRef 5.8--2022-08-16--6a71395 Mac OS X 12.5.1 x86_64 Java 18.0.2 JavaFX 18.0.2+2

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Run JabRef, use LibreOffice panel to connect to a document and run.
  2. Try to quit JabRef.
  3. Observe that JabRef window closes but the app doesn't exit; needs force quit.

Appendix

Log file (hang log from Apple crash reporter):

Hang.log.zip
@Siedlerchr
Copy link
Member

Thanks for the report, I could reproduce this. Guess we need to make sure to close the LO connection on closing
But once I closed LO, JabRef exited as well.

@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Aug 21, 2022
@Siedlerchr
Copy link
Member

Need to investigate https://forum.openoffice.org/en/forum/viewtopic.php?t=29873

Siedlerchr added a commit that referenced this issue Aug 21, 2022
@Siedlerchr
Close OO connection on exit
70cb985 
Fixes #9075
JabRef exits now, LO document is kept open
Siedlerchr added a commit that referenced this issue Aug 21, 2022
@Siedlerchr
Close OO connection on exit
1002d6f 
Fixes #9075
JabRef exits now, LO document is kept open
@Siedlerchr Siedlerchr mentioned this issue Aug 21, 2022
Merged
6 tasks
Siedlerchr added a commit that referenced this issue Aug 22, 2022
@Siedlerchr
Close OO connection on JabRef exit (#9076)
a255311 
* Close OO connection on exit

Fixes #9075
JabRef exits now, LO document is kept open

* checkstyle

* Update src/main/java/org/jabref/gui/openoffice/OOBibBaseConnect.java


* Update src/main/java/org/jabref/gui/openoffice/OOBibBaseConnect.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs openoffice/libreoffice
Projects
Bugs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close OO connection on JabRef exit JabRef/jabref
2 participants
@iandol @Siedlerchr