Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlinked File Importer: Does not import all importable files #8444

Closed
2 tasks done
falschgeldkind opened this issue Jan 18, 2022 · 7 comments · Fixed by #8582
Closed
2 tasks done

Unlinked File Importer: Does not import all importable files #8444

falschgeldkind opened this issue Jan 18, 2022 · 7 comments · Fixed by #8582
Labels
bug Confirmed bugs or reports that are very likely to be bugs external files

Comments

@falschgeldkind
Copy link
Contributor

JabRef version

5.5 (latest release)

Operating system

GNU / Linux

Details on version and operating system

No response

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Create new library
  2. Lookup -> Search for unlinked local files
  3. Select a directory with a lot of pdf documents (maybe at least 100 pdf)
    before_1stsearching
  4. click on search
    after_searching
  5. select all, click on import
    ImportHandler_breakpoint_line_72
  6. wait, after that all documents should have been imported
    ImportHandler_breakpoint_line_137
    Import_Results
  7. be surprised that not all documents were imported
    -> check that by clicking on search again
    after_2ndsearching

Appendix

Not sure what to write here

if you need any more information just get back to me
@falschgeldkind
Copy link
Contributor Author

please note that all entries in the Import results were shown as succesfull

@ThiloteE
Copy link
Member

Related issue in the forum: https://discourse.jabref.org/t/unlinked-file-importer-does-not-import-all-importable-files/3150

@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs external files labels Jan 18, 2022
@Siedlerchr
Copy link
Member

Thanks again for the detailed analysis! I really wonder where the difference comes from. MIght be something in the actual importing step.

@suppenkaspar109
Copy link

Can confirm this bug. What is also kind of strange, that same entries are added multiple time if you run the import process multiple times.

ni-wi added a commit to ni-wi/jabref that referenced this issue Mar 19, 2022
@ni-wi
fix import of unlinked files (JabRef#8444)
d0a15b8
@ni-wi ni-wi mentioned this issue Mar 19, 2022
Merged
5 tasks
@falschgeldkind
Copy link
Contributor Author

falschgeldkind commented Mar 21, 2022 •
edited
Loading

Thats awesome! Is it foreseeable whether the fix will be included in the next Jabref version?

calixtus pushed a commit that referenced this issue Mar 21, 2022
@ni-wi
fix import of unlinked files (#8444) (#8582)
b47c29f
@Siedlerchr
Copy link
Member

@falschgeldkind A fix has jut been merged

We would like to ask you to use a development build from https://builds.jabref.org/main and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

@falschgeldkind
Copy link
Contributor Author

Yes I will try that when I'm back at work on friday

That's not a problem the library is empty anyways (thats why I want to import in bulk).

Siedlerchr added a commit that referenced this issue Mar 27, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into checkKeygenOverwrite
a7eb2f3 
* upstream/main: (104 commits)
  update test getPart (#8610)
  Add ControlHelper truncateString tests comments (#8612)
  Allow using custom SSL certificates (#8583)
  Fix protectedTerms not stored due to weaklistener (#8609)
  Fix changelog and version parsing (#8578)
  Creating more unit tests for NumericFieldComparatorTest (#8604)
  Fix merge entries dialog exceeding screen size (#8599)
  StringUtilTest new test for method GetPart (#8594)
  Use unkown entry type
  Add semantic scholar (#8575)
  Add research gate (#8580)
  fix import of unlinked files (#8444) (#8582)
  Missed l10n for fetcher fix (#8597)
  Fix some fetcher test (#8595)
  Bump slf4j-api from 2.0.0-alpha6 to 2.0.0-alpha7 in /buildSrc (#8589)
  Bump ikonli-materialdesign2-pack from 12.3.0 to 12.3.1 (#8591)
  Bump gittools/actions from 0.9.11 to 0.9.13 (#8587)
  Bump mockito-core from 4.3.1 to 4.4.0 (#8588)
  Bump flowless from 0.6.8 to 0.6.9 (#8590)
  Bump ikonli-javafx from 12.3.0 to 12.3.1 (#8592)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/EntryTypeViewModel.java
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs external files
Projects
Prioritization
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for unlinked file importer that did not import all importable files (#8444) ni-wi/jabref
4 participants
@Siedlerchr @ThiloteE @falschgeldkind @suppenkaspar109