Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entry editor columns not well adjusted #7986

Closed
ilippert opened this issue Aug 15, 2021 · 8 comments · Fixed by #8232
Closed

Entry editor columns not well adjusted #7986

ilippert opened this issue Aug 15, 2021 · 8 comments · Fixed by #8232
Labels
entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@ilippert
Copy link
Contributor

JabRef 5.3--2021-07-16--c99d61c
Linux 5.13.8-200.fc34.x86_64 amd64
Java 16.0.1
JavaFX 16+8

Screenshot from 2021-08-15 10-31-24

shows the three "columns" view of the entry editor with two left hand columns of fields.
This is the default view on my system.

This has been a visibility bug (for many months/years). I cannot see the left hand fields well.
@koppor
Copy link
Member

koppor commented Aug 15, 2021

This refs #6856 and #6191.

@Siedlerchr
Copy link
Member

See #6901 (comment) for the code

@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Aug 17, 2021
@ThiloteE
Copy link
Member

Current workaround:

  • You can move the column to the right and "disable the Related Articles Tab and the Latex Citations tab under Options -> Entry editor."
  • tick the option under Options>Entry preview>Show preview as a tab in entry editor

As long as the columns can't be adjusted well, one could argue for making the latter the default view for the Linux edition.

@xiaoxianma
Copy link
Contributor

@koppor I'm interested in this. Will take a look and work on it.

@xiaoxianma
Copy link
Contributor

xiaoxianma commented Nov 11, 2021 •
edited
Loading

The issue is impacting all "Optional fields" tabs. The problem is that when the window width is shrinking, the three columns of the entry editor are not shrinking equally. Instead, the middle column keeps the size until a minimum width size is reached. Need to make the first and second columns grow & shrink equally.

@xiaoxianma
Copy link
Contributor

@koppor just pushed a fix for the issue. Feel free to review and let me know if you have any questions. Thx!

This was referenced Nov 12, 2021
Merged
Closed
Siedlerchr pushed a commit that referenced this issue Nov 13, 2021
Fix entry editor column visibility (#8232)
5e88576 
* refactor optionalFields component

* fix #7986 optional field tab first column visibility issue

* fix format style

* fix localization lang
@ilippert
Copy link
Contributor Author

yeah, looking forward to testing this version

@Siedlerchr
Copy link
Member

Should be ready in roughly +/- half an hour.

@koppor koppor moved this to Closed in JabRef UI Improvements Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
No open projects
JabRef UI Improvements
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix entry editor column visibility
5 participants
@Siedlerchr @koppor @xiaoxianma @ilippert @ThiloteE