Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck in creating library entry after Fetcher 'DOI' did not find an entry ... #7870

Closed
WolfgangFahl opened this issue Jul 4, 2021 · 12 comments
Assignees
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui

Comments

@WolfgangFahl
Copy link

Steps to reproduce the behavior:

Im am trying to add a reference to
http://dx.doi.org/10.2777/1524
by creating a new article entry using the doi 10.2777/1524:
grafik
grafik

and get stuck here. I'd expect that after this error message i'd be able to create the entry manually.

@koppor koppor added the ui label Jul 4, 2021
@koppor
Copy link
Member

koppor commented Jul 4, 2021

Video of the issue: https://www.loom.com/share/1a7fb6101a8e4d499c4a39f2d9f11108

Solution approach:

Add buttons: "Add entry manually" and "Return to dialog" (Refs koppor#149)

@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Jul 4, 2021
@betochf
Copy link

betochf commented Jul 7, 2021

I think I could solve this, it should be a customDialog instead of errorDialog?

@koppor
Copy link
Member

koppor commented Jul 13, 2021

I am not sure whether a JavaFX class CustomDialog exists. It should be a custom dialog (see other dialogs in JabRef). HTH.

@Siedlerchr
Copy link
Member

Siedlerchr commented Jul 13, 2021

Have a look at JabRefDialogService . We provide different dialog (and also custom dialog) implementations to use

@mrcstan
Copy link
Contributor

mrcstan commented Oct 16, 2021

Is anyone working on this issue? It not, I would like to work on it.

@koppor
Copy link
Member

koppor commented Oct 17, 2021

@mrcstan Sure - go ahead!

@mrcstan
Copy link
Contributor

mrcstan commented Oct 31, 2021

@koppor / others, I plan to create a dialog box that allows user to either "Add entry manually" or return to the original dialog box as suggested above. After the "Add entry manually" button is clicked by the user, should the Others menu open allowing user to choose the article type? I am guessing "Return to dialog" means returning to the original dialog box where the DOI can be changed? I am currently using an existing dialog box called showConfirmationDialogAndWait (see attached screenshot). When "Add entry manually" is click, a true value will be returned and the user will be directed to the menu that allows them to add the entry manually. Let me know if that is in the correct direction.
image

mrcstan added a commit to mrcstan/jabref that referenced this issue Oct 31, 2021
…n article for manual entry when the fetcher DOI failed to find an entry for an ID (JabRef#7870)
mrcstan added a commit to mrcstan/jabref that referenced this issue Oct 31, 2021
…n article for manual entry when the fetcher DOI failed to find an entry for an ID [JabRef#7870]
@mrcstan
Copy link
Contributor

mrcstan commented Nov 1, 2021

I submitted a pull request 8203. I received an error during the test "Deployment / Create installer and portable version for macOS." The error message is "Run apple-actions/import-codesign-certs@v1
80 Error: At least one of p12-filepath or p12-file-base64 must be provided." I was able to install the code successfully on my MacOS machine, and I don't think I have changed anything that affects the installation. Let me know if you have any hint what could be causing the issue.

@Siedlerchr
Copy link
Member

Thanks for the interest! We have a checkstyle config https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace

And don't worry about the Mac deployment it will fail every time on forks because it accesses some signing keys that are stored in GitHub secrets and are not available when the Action runs on a fork

koppor pushed a commit that referenced this issue Nov 8, 2021
…e new entry dialog box when failed to find DOI ID ... #7870 (#8203)
@evanpickett
Copy link
Contributor

Are there still any problems regarding this issue that might need to be addressed? I'm only asking because the status is still listed as "open"

@WolfgangFahl
Copy link
Author

I have not seen a release yet that would have the improvement. Is there some kind of prerelease to check?

@Siedlerchr
Copy link
Member

We would like to ask you to use a development build from https://builds.jabref.org/main and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

mrcstan added a commit to mrcstan/jabref that referenced this issue Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui
Projects
None yet
Development

No branches or pull requests

6 participants