Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch "Cleanup entries" function does not work if order by file name #6620

Closed
avm19 opened this issue Jun 19, 2020 · 1 comment
Closed

Batch "Cleanup entries" function does not work if order by file name #6620

avm19 opened this issue Jun 19, 2020 · 1 comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs cleanup-ops external files status: stale

Comments

@avm19
Copy link

avm19 commented Jun 19, 2020

The following operation:

Quality -> Cleanup entries -> Make paths of linked files relative (if possible)

does not work properly if applied to a group of selected entries when the entries are sorted by "File".

Steps to reproduce:

  • [provided some files in the database have absolute path in the "File" field and can be converted to relative paths, and the base directory path is specified for the database to make it possible]
  • select those files (shift+Click)
  • Quality -> Cleanup entries -> check Make paths of linked files relative (if possible), uncheck everything else
  • Ok

Expected behaviour:
The operation is applied to all files (abs. paths change to relative ones)

Observed behaviour:
The operation is completed in respect of no more than one entry.

User fix:
If the database is sorted by a different field / column, then everything works as expected.

It is reasonable to suspect that the bug is due to the group of entries being referred by their current position in the database list. After the operation is completed for one file, the order of the entries in the list is changed.

Apologies for having it tested only for 2 weeks old master build. If someone fixed it within last 2 weeks, it should be easy to remember. (Also the bug doesn't seem to be very important)

JabRef 5.1--2020-06-03--2f0aed9
Windows 10 10.0 amd64
Java 14.0.1

@Siedlerchr Siedlerchr added cleanup-ops external files bug Confirmed bugs or reports that are very likely to be bugs labels Jun 19, 2020
@github-actions
Copy link
Contributor

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

  • If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
  • Provide further steps or information on how to reproduce this issue.
  • Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
  • If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

koppor pushed a commit that referenced this issue Aug 15, 2023
795ad0c772 Create duale-hochschule-baden-wurttemberg-department-of-international… (#6622)
18ee055259 Create Howard Hughes Medical Institute  (#6615)
ad5bedc1d2 Update the-journal-of-clinical-investigation.csl (#6607)
6a938ccd0e Update haute-ecole-de-gestion-de-geneve-iso-690.csl (#6621)
289fda356b Update haute-ecole-de-gestion-de-geneve-iso-690.csl (#6620)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 795ad0c77258cb7e01f3413123b5b556b4cb6a98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs cleanup-ops external files status: stale
Projects
None yet
Development

No branches or pull requests

2 participants