Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more menu items to tab context menu #6527

Closed
koppor opened this issue May 26, 2020 · 6 comments · Fixed by #6551 or #8264
Closed

Add more menu items to tab context menu #6527

koppor opened this issue May 26, 2020 · 6 comments · Fixed by #6551 or #8264
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui

Comments

@koppor
Copy link
Member

koppor commented May 26, 2020

JabRef 3.8.2:

grafik

The old implementation is available at 88bae85. Maybe, this some sort of inspiration.

@Hollyqqqqq
Copy link
Contributor

Hi, I am interested in this issue.
If no one is working on this issue, I'll try to work on it these two days.^_^

@Hollyqqqqq
Copy link
Contributor

Hi, I have add the menu items as following:
image

Is it enough or it needs more other menu items?

@Siedlerchr
Copy link
Member

@Hollyqqqqq Thanks, that looks good to me! That should be sufficient for the moment

@Hollyqqqqq
Copy link
Contributor

OK^_^
I will try to write some tests, and then create pr.

@Hollyqqqqq
Copy link
Contributor

Sorry, I got stucked into how to run tests although I have some ideas to write tests. There are always errors like "Error(19, 33) java: program package org.jabref.logic.journals not exist" when running both original tests and the tests I added. I have troubles to solve these errors.

Then, I will just create pr for codes that fix this issue and skip the tests codes for the moment.

@tobiasdiez
Copy link
Member

Thanks to @Hollyqqqqq this is now implemented in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

koppor pushed a commit that referenced this issue Jun 1, 2023
6b7fdff8cb Create journal-of-the-american-philosophical-association.csl (#6542)
9bae9efc55 Update german-council-of-economic-experts.csl (#6562)
256250be9c Update springer-vancouver-brackets.csl (#6546)
f422ca9c9a Update turabian-fullnote-bibliography.csl (#6540)
2833b5d5d5 Update mots.csl (#6556)
44758704b0 Update and rename harvard-the-university-of-melbourne.csl to dependen… (#6547)
08e65fc8e1 Update ieee-with-url.csl (#6514)
06e98f4387 Fix erroneous comma in ACL in-text citation (#6553)
72e16a19cd Update bibliothek-forschung-und-praxis.csl (#6527)
50bae82394 Create Food and Agriculture Organization of the United Nations (numeric) (#6544)
234a3c35d8 Update bern-university-of-applied-sciences-school-of-agricultural-for… (#6552)
3e9e2d6e93 Fix et al and name settings in universitat bern institut fur sozialanthropologie (#6554)
e8e06888fe Update harvard-university-of-the-west-of-england.csl (#6520)
dbbe5c1a95 Update united-states-international-trade-commission.csl (#6535)
b985431f03 Update american-society-for-horticultural-science.csl (#6543)
e1ff9f5546 Sort APA and derivatives on displayed date, not full date (#6545)
7302832d6d Localize original-work-published in APA (#6388)
77a61c0d82 Update united-states-international-trade-commission.csl (#6526)
541807a057 Update the-accounting-review.csl (#6521)
708626357a  Update united-states-international-trade-commission

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 6b7fdff8cb0fb45b342e8ac319634bf18168c73d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui
Projects
Archived in project
4 participants