Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dash should not be reported as illegal BibTeX-Key #6295

Closed
JoKalliauer opened this issue Apr 16, 2020 · 2 comments · Fixed by #6300
Closed

dash should not be reported as illegal BibTeX-Key #6295

JoKalliauer opened this issue Apr 16, 2020 · 2 comments · Fixed by #6300
Labels
bug Confirmed bugs or reports that are very likely to be bugs

Comments

@JoKalliauer
Copy link
Contributor

JabRef 5.1--2020-03-23--67daf36
Windows 10 10.0 amd64
Java 14

Steps to reproduce the behavior:
BibTeX-Key conaining dashes are reported as illegal BibTeX-Key
Screenshot 2020-04-16 12 09 28

But according to @Siedlerchr in #4709 (comment)

Well, dash is a perfectly legal char in a bibtex/biblatex key: Forbidden are only these symbols: " # % ' ( ) , = { }
@Siedlerchr
Copy link
Member

Siedlerchr commented Apr 16, 2020 •
edited
Loading

Duplicate of #6252 and refs #6257

I don't know why we added the dash to the list of illegal chars, although it's legal I think

@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Apr 16, 2020
dextep added a commit to dextep/jabref that referenced this issue Apr 16, 2020
@dextep
Fix JabRef#6295.
d8ba2d5 
Remove dash from illegal chars.
@dextep dextep mentioned this issue Apr 16, 2020
Closed
5 tasks
dextep added a commit to dextep/jabref that referenced this issue Apr 16, 2020
@dextep
Remove dash from illegal characters. Fix JabRef#6295 JabRef#6257 JabR…
2b7fad5 
…ef#6252
@dextep dextep mentioned this issue Apr 16, 2020
Merged
5 tasks
This was referenced Apr 16, 2020
Merged
Closed
@koppor
Copy link
Member

koppor commented Apr 16, 2020

It was introduced in #4713, and released in JabRef 5.0.

dextep added a commit to dextep/jabref that referenced this issue May 3, 2020
@dextep
Remove dash from illegal characters. Fix JabRef#6295 JabRef#6257 JabR…
ae8b183 
…ef#6252
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
koppor pushed a commit that referenced this issue Jan 1, 2023
Squashed 'buildres/csl/csl-styles/' changes from 84dba23..43566f2
bec415c 
43566f2 Update molecular-oncology.csl (#6354)
38f2b5f Update san-francisco-estuary-and-watershed-science.csl (#6350)
724cb12 Update australasian-journal-of-philosophy.csl (#6344)
df6af86 Fix webpage in-text citation for council-of-science-editors-author-date.csl (#6318)
6900b58 Add month to magazine for Bluebook
e0a8148 Update cambridge-university-press-author-date-cambridge-a.csl (#6345)
0823448 Add space & comma before pp (#6343)
ff38cd2 Update american-journal-of-respiratory-and-critical-care-medicine.csl (#6341)
8727dfb Update early-music-history.csl (#6323)
1154354 Update boletin-de-pediatria.csl (#6310)
f25438e Update pravnik.csl (#6309)
db7a4ae Update zoological-journal-of-the-linnean-society.csl (#6304)
6c043a7 Create polygraphia.csl (#6307)
255e00c Create intellect-newgen-books.csl (#6308)
323629f Update historical-materialism.csl (#6300)
f62b70d Create european-review-of-international-studies.csl (#6301)
dff2698 Update ucl-university-college-harvard.csl (#6298)
0ce09c9 Update sciences-po-ecole-doctorale-note-french.csl (#6290)
bdd53ec Update sciences-po-ecole-doctorale-author-date.csl (#6291)
efde4d4 Create journal-of-law-medicine-ethics.csl (#6296)
7539b2c Create theses-de-sorbonne-universite.csl (#6295)
905f25a Update biochemical-society-transactions.csl (#6292)
a76a3f5 Update smithsonian-institution-scholarly-press author-date and note (#6294)
e6b6c6c Create exploration-of-targeted-anti-tumor-therapy.csl (#6276)
024c9c8 Create nys-nydanske-studier.csl (#6331)
d9ac8e1 Update vox-sanguinis.csl (#6327)
9a98e92 Remove DOI from Genetics & Molecular Biology

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 43566f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
Prioritization
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dash from illegal characters. dextep/jabref
3 participants
@Siedlerchr @koppor @JoKalliauer