-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed enhancement: Make item count in groups panel an optional feature that can be turned off #6042
Comments
Hi Tobiasdiez, If possible, I would like to work in this issue. Can you assign it to me? Gennadiy |
Corrected resources file after not passing the test
* Init changes * Init changes * Восстановлено исходное состояние мастера * Просто коммит * Issue #6042 fixed * Issue #6042 fixed Corrected resources file after not passing the test * - Added new property to PreferencesService and JabRefPreferences - Used this property in GroupsTabView - DisplayGroupQuantity renamed into DisplayGroupCount in GroupsTabView & GroupsTabViewModel * - removed line from JabRef_en.properties * Updated Properties file - removed line from ...da.properties; - added line to ...en.properties; * Changed GroupTreeView according to comments from Tobiasdiez Main task - disable calling "group.getHits()" method to avoid calculation of items in group. * Remove empty line Co-authored-by: Tobias Diez <[email protected]>
JabRef 5.1--2020-06-02--46fd96b I can confirm, that this has been implemented in the current dev version. I am glad to see, that by not displaying the groups item count, the CPU performance required when starting JabRef is much lower, than when the item count is shown. So this has definitely improved performance. Well done! Note, however, that changing the groups preference "Display count of items in group" to enable the item count will not take immediate effect. An item count is shown, but it is zero for all groups. Only if you restart JabRef, the item count of each group will be updated accordingly. |
Thank you very much for testing the current dev build. Glad to see that you like the improvement. |
Cheers! Yes, I am not really bothered by this - just restarting JabRef is not much of a hassle to me. But I am really happy to see, that the performance of JabRef (at least when starting JabRef - I have to figure out, whether this also makes any difference when assigning a large number of items to a group) could be improved by this approach. Thanks again for you hard work! |
8d69f16 Create university-of-hull-harvard.csl (#6146) 139dfdd Create current organic synthesis.csl (#6139) bb006c8 Update acta-universitatis-agriculturae-sueciae.csl (#6143) 5815da0 Create food-science-and-biotechnology.csl (#6132) 2702a7c Update harvard-university-for-the-creative-arts.csl (#6104) ef34543 Update economic-geology.csl (#6128) 0adcd30 Bump mathieudutour/github-tag-action from 5.6 to 6.0 (#6141) 3c36e97 Create universite-du-quebec-a-montreal-prenoms.csl (#6073) 415bc05 Bump softprops/action-gh-release from 0.1.14 to 1 (#6142) ae8c5e4 Create politique-europeenne.csl (#6074) 09cbc09 Update cell-numeric-superscript.csl (#6188) 6ee1ace Update avian-conservation-and-ecology.csl (#6191) cb5c43f Update harvard-anglia-ruskin-university.csl (#6189) 5c4f4c0 Create anais-da-academia-brasileira-de-ciencias.csl (#6066) a60dfe9 Update cardiff-university-harvard.csl (#6190) 999a45c Create sociologia-urbana-e-rurale.csl (#6042) 1bc9d62 Bluebook (#6183) a4f2a72 Oxford Brookes (#6182) 88df8d5 Delete harvard-cardiff-university-old.csl (#6180) b9302fd Update APA styles for "event" macro (#6174) d4daec6 remove DOI for printed articles organizational-studies.csl (#6176) acfc620 Create liver-transplantation.csl (#6167) 129a775 Change "event" to "event-title" (#6164) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 8d69f16
The current JabRef 5 dev version has huge performance problems with large databases, e.g.:
#5071
#5735
The same database (ca. 20,000 items; several thousands of static groups) opened with JabRef 3.8.2 does not display these performance issues.
I wonder whether some of these performance issues could be solved by a simple workaround: Make it possible to switch off the calculation of the number of items in the groups panel. In version 3.8.2 this was possible and was also suggested to do, when having performance problems. Indeed, I switched it off for my database, since otherwise it would not be possible to work with the database due to performance problems.
However, you shouldn't get rid of the background box surrounding the group item account. This box changes colour according to whether an item selected in the main table is part of a group or not, so this information should be available. In the old JabRef version this was achieved by having the name of a group underlined, which contained a selected item.
I think this rather simple (?) change could alleviate some of the performance problems reported previously. In fact, it already did with the old version 3.8.2, so you would expect to see a similar performance increase in the current dev version.
The text was updated successfully, but these errors were encountered: