Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New Group" > "Specified keywords" > "Generate groups for author last names" not working properly #5833

Closed
systemoperator opened this issue Jan 15, 2020 · 6 comments · Fixed by #7228
Labels

Comments

@systemoperator
Copy link
Contributor

systemoperator commented Jan 15, 2020

When selecting "New Group" > "Specified keywords" > "Generate groups for author last names", providing any group name, entering "author" in the field "Field to group by" and clicking "OK", then hardly any (or even none) of the generated groups with the authors' last names have entries in it. Most badges have the value 0.

I'm using the latest JabRef 5 master build on Ubuntu 16.04.

image

@systemoperator systemoperator changed the title "New Group" > "Automatically create groups" > "Generate groups by for author last names" not working properly "New Group" > "Automatically create groups" > "Generate groups for author last names" not working properly Jan 15, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

  • If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
  • Provide further steps or information on how to reproduce this issue.
  • Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
  • If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

@systemoperator
Copy link
Contributor Author

Issue still persists. Description has been updated.

@Siedlerchr
Copy link
Member

Seems like JabRef creates group for the first name as well, but only fills the ones for the last names. I don't really understand how it's working

@systemoperator systemoperator changed the title "New Group" > "Automatically create groups" > "Generate groups for author last names" not working properly "New Group" > "Specified keywords" > "Generate groups for author last names" not working properly Dec 19, 2020
@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

Should I look at it as part of the solution to #6394? I haven't looked at the details of this one but it would surprise me if it does not have overlap with the issues I am having updating the count badge and refreshing the content.

The scope of #7173 keeps expanding "naturally" anyway 😧

@systemoperator
Copy link
Contributor Author

@k3KAW8Pnf7mkmdSMPHz27 If you find some time, it would be great.

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

k3KAW8Pnf7mkmdSMPHz27 commented Dec 22, 2020

There are multiple issues with getting this working properly and they are unfortunately not connected to #6394 so I won't continue with it for now, but these are my notes for now

  1. The first problem is the use of KeywordListSearchStrategy in WordKeywordGroup, this means that any author with a "," before/after the last name is ignored (e.g., Turing, Alan should not be listed under "Turing")
    1. This particular issue can be relieved by using StringSearchStrategy but then other parts of the name will be matched as well, not only last names
    2. I believe there are issues where names containing latex also doesn't work, but I have not confirmed it (e.g., GödelG{\"{o}}del)
      3. Is there a drawback to KeywordList being latex-free? (I don't remember how the global search deals with this issue)
  2. The use of BibEntry#getLatexFreeField is not going to work in all cases (e.g., institutes)
  3. Automatic keyword groups do not update in group list when keywords change #7129 should also be a problem in this issue (I have not confirmed this either)

If there is a point to making the "groups for author last names" slightly more accurate, switching to "StringSearchStrategy" is done by changing a boolean value. But it does not make the group work "properly".

koppor pushed a commit that referenced this issue Jan 15, 2022
5563ccc Update american-society-for-microbiology.csl (#5842)
19ab80f Merge pull request #5843 from POBrien333/patch-1002
d4a6c6d double trouble
424f7fe in-text >> superscript for T&F ACS style
605253c Merge pull request #5837 from POBrien333/patch-998
eb5417d Merge pull request #5838 from alessandro-gentilini/patch-1
7d2d3f5 Fix typo
9f557b5 Re-indent CSL styles
f587e60 polyglot style
3a3fe2c Create journal-fur-kulturpflanzen-journal-of-cultivated-plants.csl
cb24633 Merge pull request #5826 from dstark/patch-7
2590a6c Merge pull request #5833 from POBrien333/patch-997
5b2481e Create nist-techpubs-jres.csl (#5756)
d2a1a49 Re-indent CSL styles
42c51d1 Update tyndale-bulletin.csl
8dae693 rework style
070586b Localize IEEE dates (#5835)
588fbfe Hopefully fix sorting in CSE author-date (#5834)
1291d72 Update physiotherapy-theory-and-practice.csl
1a64076 New Style for "Neue Kriminalpolitik (Deutsch)" (#5586)
eac93a0 Create physiotherapy-theory-and-practice.csl
2e7a9f6 Merge pull request #5832 from POBrien333/patch-996
4dfad5f Update administrative-science-quarterly.csl
f56db0f Merge pull request #5829 from benthamite/patch-1
526b0b3 Update effective-altruism-wiki.csl
e5b11eb Update effective-altruism-wiki.csl
f2a7301 Update effective-altruism-wiki.csl
5b166c2 Update university-of-roehampton-harvard.csl (#5831)
b231514 Update european-society-of-cardiology.csl (#5519)
dbd902c Re-indent CSL styles
fe8892b Update effective-altruism-wiki.csl
734fa7d Update effective-altruism-wiki.csl
2430a32 Create effective-altruism-wiki.csl
a5101b6 update modern-pathology.csl (#5828)
16f77c8 Update tyndale-bulletin.csl
ea8804e Create the-korean-journal-of-mycology.csl (#5822)
22d8be0 Patch 3 (#5825)
0220ba2 Create jcom.csl (#5819)
cd7b72b Create taylor-and-francis-council-of-science-editors-numeric.csl (#5824)
0033383 Create gomis-senegalese-medicine-thesis.csl (#5774)
b221bcc Create mycobiology.csl (#5821)
d7056f9 Re-indent CSL styles
04ae08b Update tyndale-bulletin.csl
24bd577 Re-indent CSL styles
e08d431 clean up logging
f6ac2a6 Update tyndale-bulletin.csl
e4c07f8 this should be the PR repo name
7f9936c fetch pull request from originating repo
f232f51 Update tyndale-bulletin.csl
e2ae4fc Update tyndale-bulletin.csl
f09f8db Update Sheldon to csl-styles 2.0
a4d7dec re-indent style
a903664 sheldon
7db75fc sheldon
f08dc96 sheldon
35b8bfa sheldon
04e28ca pull req checkout
9c9d061 pull req checkout
9249490 sheldon reindent
9792be6 sheldon reindent
3bced06 reindent & commit
7cc9735 Update styles README and GitHub Actions with 1.0.2 information (#5803)
205c4ea remaining dependents
9458056 fix broken styles
07ba7af fix dependents
e2e7842 Fix term hacks for transition to CSL 1.0.2 (#5801)
5c8c5e9 Replace "sub verbo" with "sub-verbo" (#5799)
7ec637c Fix CSL styles
bcd3054 update to csl/citeproc-ruby 2.0
ec13830 bundle update

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 5563ccc
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants