Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding files with non-alphabetical characters in title #4342

Closed
tb77phd opened this issue Sep 13, 2018 · 24 comments · Fixed by #7338
Closed

Finding files with non-alphabetical characters in title #4342

tb77phd opened this issue Sep 13, 2018 · 24 comments · Fixed by #7338
Labels
external files status: waiting-for-feedback The submitter or other users need to provide more information about the issue

Comments

@tb77phd
Copy link

tb77phd commented Sep 13, 2018

JabRef version 4.3.1 on Windows 10 64-bit (I don't have administrative rights to install developer snapshots, e.g. version 5.0)

I like to use regular expression search when linking local files and use the following:
**/.[title].\.[extension]

As far as I know, that should search in the directory and subdirectories of the main file directory for files that contain the title and the proper extension (.pdf). Contain, right? The file name does not need to start with the title.

However, choosing an article in my bibliography and pressing F7 does nothing (status bar simply tells that it finished and found nothing).

What does F7 (Automatically set file links) do? I've tested with many files and get the same result, even when making sure the file name contains no special characters or anything like that.

@tb77phd
Copy link
Author

tb77phd commented Sep 18, 2018

Okay, after a bit more playing around, it seems that a regular dash is a character that makes F7 fail. In fact, it seems characters in the title (in the file name) that are not regular letters make F7 fail.


Example 1
File: BEEMAN & PINCUS - PHYS REV 1968 - Nuclear Spin-Lattice Relaxation in Magnetic Insulators.pdf

Title in JabRef:
Nuclear Spin-Lattice Relaxation in Magnetic Insulators

F7 does not find the file, unless I change the filename to
BEEMAN & PINCUS - PHYS REV 1968 - Nuclear Spin Lattice Relaxation in Magnetic Insulators.pdf.
(Removing the dash in "Spin-Lattice".)


Example 2
File: GUO ea - INORG CHEM COMMUN 2010 - Ferroelectric Metal Organic Framework (MOF).pdf

Title in JabRef:
Ferroelectric Metal Organic Framework (MOF)

F7 does not find the file, unless I change the filename to
GUO ea - INORG CHEM COMMUN 2010 - Ferroelectric Metal Organic Framework MOF.pdf.
(Removing the parentheses around "MOF".)


Note: in both cases, I did not need to change the title in JabRef, only in the filename.

@jonasstein
Copy link

Could you check, if it was really a -? Perhaps it was one of the UTF-8 symbols similar to -.

@tb77phd
Copy link
Author

tb77phd commented Sep 21, 2018

I did by removing it and then retyping with the regular dash. No change. F7 only linked when I removed the dash completely. And in my second example, there is no dash in the title, but parentheses.

@tb77phd
Copy link
Author

tb77phd commented Sep 24, 2018

I installed the 5.0-dev--snapshot on my personal computer (also Win10-64) and repeated the process. Same thing happens. F7 can't find the file unless I remove the dash (or the parentheses in my second example).

@tb77phd
Copy link
Author

tb77phd commented Oct 3, 2018

Out of curiosity, I tested to instead link using the bibtexkey, i.e., using **/.[bibtexkey]..[extension] as the regular expression. I chose to invoke dashes in my bibtexkeys so the examples above got the key Beeman-PR-1968 and I also renamed the local pdf file to this (Beeman-PR-1968.pdf).

No issue in finding the file this time when invoking "Automatically set file links" (F7) even though it contains a dash.

So... why can't a title search handle dashes and other characters but a bibtexkey search can?

koppor added a commit that referenced this issue Jan 2, 2020
b2fbe15 APA 7th edition (#4419)
c236ade Create BFCN.csl (#4481)
25d40cd Update iso690-full-note-cs.csl (#4480)
5de3904 Update budownictwo-i-architektura-pl.csl (#4479)
9d9c1da Add files via upload (#4478)
96200b0 Create instituto-alberto-luiz-coimbra-de-pos-graduacao-e-pesquisa-de-… (#4476)
8aa9cb0 Update APA journal styles (#4475)
8549afa Update in-text citation for legal_case for BJPS (#4470)
71c9e4d Update surgical-neurology-international.csl (#4472)
a9dac17 Create FUNDING.yml
633e864 Create helsingin-yliopisto-teologinen-tiedekunta-teologian-tyyli.csl (#4303)
8797c01 Create romanian-iso-690-full-note-with-ibid-romanian.csl (#4465)
c1519e1 Create assosiation-of-firearms-and-toolmark-examiners.csl (#4468)
c974e30 Update ieee.csl (#4467)
a1b7386 Update stale.yml (#4466)
db549dd Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#4462)
2822437 Update .travis.yml (#4463)
3d72c62 WIP: Adding deprecation notice to DIN1505-2 saying it has been superseded by ISO 690 (#4454)
1928c2b Fix links after KI update
fad65b7 Turn Kidney International into AMA dependent
6357af5 Update association-for-computing-machinery.csl (#4459)
eab02ea Create berlin-school-of-economics-and-law-international-marketing-man… (#3774)
a3e3d97 One more metadata fix
e7d5071 Some Sheldon metadata fixes
3ad4260 Create jurnal-sains-farmasi-dan-klinis.csl (#4455)
46370dc Add "AIMS Press" journals (#4458)
57fca07 Update association-for-computing-machinery.csl (#4456)
6fa90ed Add "Muséum national d'Histoire naturelle" journal styles (#4457)
7faf0b0 Bundle update
e3c1f85 Create cryptogamie, bryologie (#4350)
525bba5 Create iso690-full-note-cs.csl (#4414)
932fad5 Create iso690-author-date-de.csl (#4344)
ab23108 Create mbts-fullnote-bibliography.csl (#4363)
c163008 Create associacao-brasileira-de-normas-tecnicas-ibict-full.csl (#4202)
5586bbc Create associacao-brasileira-de-normas-tecnicas-ibict-initials.csl (#4203)
483efcb Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-service-engineering.csl (#4442)
92f437d Create independent style for molecular-nutrition-and-food-research.csl… (#4342)
0d7f481 Update taylor-and-francis-council-of-science-editors-author-date.csl (#4385)
2b2786b Create ritid-timarit-hugvisindastofnunnar.csl (#4315)
9534999 Create jsbm.csl (#4371)
b390657 Changed term on access macro, added rules for bill (#4407)
95c24f9 Create ecausp-abnt.csl (#4420)
66ca962 Reindent/reorder
91fefee Create materials-express.csl (#4445)
ea5d50b Create institut-catholique-de-paris.csl (#4450)
a4c07e2 Create institut-catholique-de-paris.csl (#4374)
8a17ae0 Update canadian-geotechnical-journal.csl (#4447)
7165db0 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (#4448)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: b2fbe15
github-actions bot pushed a commit that referenced this issue Jan 2, 2020
b2fbe15 APA 7th edition (#4419)
c236ade Create BFCN.csl (#4481)
25d40cd Update iso690-full-note-cs.csl (#4480)
5de3904 Update budownictwo-i-architektura-pl.csl (#4479)
9d9c1da Add files via upload (#4478)
96200b0 Create instituto-alberto-luiz-coimbra-de-pos-graduacao-e-pesquisa-de-… (#4476)
8aa9cb0 Update APA journal styles (#4475)
8549afa Update in-text citation for legal_case for BJPS (#4470)
71c9e4d Update surgical-neurology-international.csl (#4472)
a9dac17 Create FUNDING.yml
633e864 Create helsingin-yliopisto-teologinen-tiedekunta-teologian-tyyli.csl (#4303)
8797c01 Create romanian-iso-690-full-note-with-ibid-romanian.csl (#4465)
c1519e1 Create assosiation-of-firearms-and-toolmark-examiners.csl (#4468)
c974e30 Update ieee.csl (#4467)
a1b7386 Update stale.yml (#4466)
db549dd Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (#4462)
2822437 Update .travis.yml (#4463)
3d72c62 WIP: Adding deprecation notice to DIN1505-2 saying it has been superseded by ISO 690 (#4454)
1928c2b Fix links after KI update
fad65b7 Turn Kidney International into AMA dependent
6357af5 Update association-for-computing-machinery.csl (#4459)
eab02ea Create berlin-school-of-economics-and-law-international-marketing-man… (#3774)
a3e3d97 One more metadata fix
e7d5071 Some Sheldon metadata fixes
3ad4260 Create jurnal-sains-farmasi-dan-klinis.csl (#4455)
46370dc Add "AIMS Press" journals (#4458)
57fca07 Update association-for-computing-machinery.csl (#4456)
6fa90ed Add "Muséum national d'Histoire naturelle" journal styles (#4457)
7faf0b0 Bundle update
e3c1f85 Create cryptogamie, bryologie (#4350)
525bba5 Create iso690-full-note-cs.csl (#4414)
932fad5 Create iso690-author-date-de.csl (#4344)
ab23108 Create mbts-fullnote-bibliography.csl (#4363)
c163008 Create associacao-brasileira-de-normas-tecnicas-ibict-full.csl (#4202)
5586bbc Create associacao-brasileira-de-normas-tecnicas-ibict-initials.csl (#4203)
483efcb Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-service-engineering.csl (#4442)
92f437d Create independent style for molecular-nutrition-and-food-research.csl… (#4342)
0d7f481 Update taylor-and-francis-council-of-science-editors-author-date.csl (#4385)
2b2786b Create ritid-timarit-hugvisindastofnunnar.csl (#4315)
9534999 Create jsbm.csl (#4371)
b390657 Changed term on access macro, added rules for bill (#4407)
95c24f9 Create ecausp-abnt.csl (#4420)
66ca962 Reindent/reorder
91fefee Create materials-express.csl (#4445)
ea5d50b Create institut-catholique-de-paris.csl (#4450)
a4c07e2 Create institut-catholique-de-paris.csl (#4374)
8a17ae0 Update canadian-geotechnical-journal.csl (#4447)
7165db0 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (#4448)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: b2fbe15
github-actions bot pushed a commit to calixtus/jabref that referenced this issue Jan 10, 2020
bfffaed APA: Fix sort order for in-text citations (JabRef#4495)
c48d08b Add "Blood Cancer Discovery" for AACR (JabRef#4492)
f628cb2 Medizinische Fakultät Mannheim - Numerisch (JabRef#4490)
77876a4 Improve legal cites for british-journal-of-political-science (JabRef#4488)
3c0c4ee Create apa-with-abstract.csl (JabRef#4487)
a26fa95 Update afte-journal.csl (JabRef#4489)
a7bf678 Create agriculturae-conspectus-scientificus.csl (JabRef#4491)
bb01625 Make ET&C dependent of CSE (JabRef#4483)
b4418ef Create ahmad-ibrahim-kulliyyah-of-laws-international-islamic-universi… (JabRef#4482)
22872d2 APA: Use "et al." in Dutch (JabRef#4484)
5f6c080 Update weed-research.csl (JabRef#4485)
b2fbe15 APA 7th edition (JabRef#4419)
c236ade Create BFCN.csl (JabRef#4481)
25d40cd Update iso690-full-note-cs.csl (JabRef#4480)
5de3904 Update budownictwo-i-architektura-pl.csl (JabRef#4479)
9d9c1da Add files via upload (JabRef#4478)
96200b0 Create instituto-alberto-luiz-coimbra-de-pos-graduacao-e-pesquisa-de-… (JabRef#4476)
8aa9cb0 Update APA journal styles (JabRef#4475)
8549afa Update in-text citation for legal_case for BJPS (JabRef#4470)
71c9e4d Update surgical-neurology-international.csl (JabRef#4472)
a9dac17 Create FUNDING.yml
633e864 Create helsingin-yliopisto-teologinen-tiedekunta-teologian-tyyli.csl (JabRef#4303)
8797c01 Create romanian-iso-690-full-note-with-ibid-romanian.csl (JabRef#4465)
c1519e1 Create assosiation-of-firearms-and-toolmark-examiners.csl (JabRef#4468)
c974e30 Update ieee.csl (JabRef#4467)
a1b7386 Update stale.yml (JabRef#4466)
db549dd Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (JabRef#4462)
2822437 Update .travis.yml (JabRef#4463)
3d72c62 WIP: Adding deprecation notice to DIN1505-2 saying it has been superseded by ISO 690 (JabRef#4454)
1928c2b Fix links after KI update
fad65b7 Turn Kidney International into AMA dependent
6357af5 Update association-for-computing-machinery.csl (JabRef#4459)
eab02ea Create berlin-school-of-economics-and-law-international-marketing-man… (JabRef#3774)
a3e3d97 One more metadata fix
e7d5071 Some Sheldon metadata fixes
3ad4260 Create jurnal-sains-farmasi-dan-klinis.csl (JabRef#4455)
46370dc Add "AIMS Press" journals (JabRef#4458)
57fca07 Update association-for-computing-machinery.csl (JabRef#4456)
6fa90ed Add "Muséum national d'Histoire naturelle" journal styles (JabRef#4457)
7faf0b0 Bundle update
e3c1f85 Create cryptogamie, bryologie (JabRef#4350)
525bba5 Create iso690-full-note-cs.csl (JabRef#4414)
932fad5 Create iso690-author-date-de.csl (JabRef#4344)
ab23108 Create mbts-fullnote-bibliography.csl (JabRef#4363)
c163008 Create associacao-brasileira-de-normas-tecnicas-ibict-full.csl (JabRef#4202)
5586bbc Create associacao-brasileira-de-normas-tecnicas-ibict-initials.csl (JabRef#4203)
483efcb Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-service-engineering.csl (JabRef#4442)
92f437d Create independent style for molecular-nutrition-and-food-research.csl… (JabRef#4342)
0d7f481 Update taylor-and-francis-council-of-science-editors-author-date.csl (JabRef#4385)
2b2786b Create ritid-timarit-hugvisindastofnunnar.csl (JabRef#4315)
9534999 Create jsbm.csl (JabRef#4371)
b390657 Changed term on access macro, added rules for bill (JabRef#4407)
95c24f9 Create ecausp-abnt.csl (JabRef#4420)
66ca962 Reindent/reorder
91fefee Create materials-express.csl (JabRef#4445)
ea5d50b Create institut-catholique-de-paris.csl (JabRef#4450)
a4c07e2 Create institut-catholique-de-paris.csl (JabRef#4374)
8a17ae0 Update canadian-geotechnical-journal.csl (JabRef#4447)
7165db0 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4448)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: bfffaed
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this issue Feb 1, 2020
e2416fa Update clinical-and-experimental-optometry.csl (JabRef#4538)
e71363e Create geriatrie-et-psychologie-neuropsychiatrie-du-vieillissement.csl (JabRef#4543)
cdd973e APA: Add "personal communication" localization (JabRef#4539)
77bdb6f Create eksploatacja-i-niezawodnosc (JabRef#4531)
7858966 Ready: Update psychological-medicine.csl (JabRef#4536)
264141a Create south-african-actuarial-journal.csl (JabRef#4534)
1fde301 Create pakistan-journal-of-agricultural-sciences.csl (JabRef#4535)
3020eb3 Update hochschule-fur-soziale-arbeit-fhnw.csl (JabRef#4533)
57c8122 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4530)
17c178f Update zeitschrift-fur-internationale-beziehungen.csl (JabRef#4527)
14cf589 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4528)
ca60d6e Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4524)
74c5ae9 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4526)
999e124 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4521)
caabe36 Fix psychiatric services
f50e6f0 Add files via upload (JabRef#4519)
c728658 Create harvard-lancaster-university.csl (JabRef#4520)
11e9ac9 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4511)
101b81c Update agriculturae-conspectus-scientificus.csl (JabRef#4510)
615377e Create international-journal-of-population-data-science.csl (JabRef#4517)
fe7cb69 Update university-of-york-apa.csl
f0c7374 Fix AGLC Subsequents
6a8ec90 More Uni Gottingen fixes
9c0f5c6 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4460)
22ef83d Update Universitatsmedizin Gottingen
d2f90c9 Create drying-technology.csl (JabRef#4515)
01e339b Create terrorism-and-political-violence.csl (JabRef#4514)
6414c15 Create international-journal-of-hyperthermia.csl (JabRef#4513)
f80b38c Create Sciences Po - Ecole doctorale (note, French) (JabRef#4486)
6a22929 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4508)
19c89f5 Create citation-compass-apa-note.csl (JabRef#4500)
fe72590 Chicago fixes & add no-ibid variant (JabRef#4503)
d602477 Update agriculturae-conspectus-scientificus.csl (JabRef#4505)
8a8911b Create mediterranean-journal-of-chemistry.csl (JabRef#4506)
ce77b28 Create conservation-and-society.csl (JabRef#4507)
25a5092 Add IMS journals (JabRef#4496)
a39430e Create rmit-university-harvard.csl (JabRef#4504)
830aa7b Update john-benjamins-publishing-company-collective-volumes.csl (JabRef#4444)
43e9216 Create PHBern IVP (JabRef#4427)
a052fd6 Create Publications du Groupe d'anthropologie et d'archéologie funéra… (JabRef#4499)
a7e12e1 Further improve legal cites for BJPS (JabRef#4497)
744a507 Update agriculturae-conspectus-scientificus.csl (JabRef#4498)
bfffaed APA: Fix sort order for in-text citations (JabRef#4495)
c48d08b Add "Blood Cancer Discovery" for AACR (JabRef#4492)
f628cb2 Medizinische Fakultät Mannheim - Numerisch (JabRef#4490)
77876a4 Improve legal cites for british-journal-of-political-science (JabRef#4488)
3c0c4ee Create apa-with-abstract.csl (JabRef#4487)
a26fa95 Update afte-journal.csl (JabRef#4489)
a7bf678 Create agriculturae-conspectus-scientificus.csl (JabRef#4491)
bb01625 Make ET&C dependent of CSE (JabRef#4483)
b4418ef Create ahmad-ibrahim-kulliyyah-of-laws-international-islamic-universi… (JabRef#4482)
22872d2 APA: Use "et al." in Dutch (JabRef#4484)
5f6c080 Update weed-research.csl (JabRef#4485)
b2fbe15 APA 7th edition (JabRef#4419)
c236ade Create BFCN.csl (JabRef#4481)
25d40cd Update iso690-full-note-cs.csl (JabRef#4480)
5de3904 Update budownictwo-i-architektura-pl.csl (JabRef#4479)
9d9c1da Add files via upload (JabRef#4478)
96200b0 Create instituto-alberto-luiz-coimbra-de-pos-graduacao-e-pesquisa-de-… (JabRef#4476)
8aa9cb0 Update APA journal styles (JabRef#4475)
8549afa Update in-text citation for legal_case for BJPS (JabRef#4470)
71c9e4d Update surgical-neurology-international.csl (JabRef#4472)
a9dac17 Create FUNDING.yml
633e864 Create helsingin-yliopisto-teologinen-tiedekunta-teologian-tyyli.csl (JabRef#4303)
8797c01 Create romanian-iso-690-full-note-with-ibid-romanian.csl (JabRef#4465)
c1519e1 Create assosiation-of-firearms-and-toolmark-examiners.csl (JabRef#4468)
c974e30 Update ieee.csl (JabRef#4467)
a1b7386 Update stale.yml (JabRef#4466)
db549dd Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (JabRef#4462)
2822437 Update .travis.yml (JabRef#4463)
3d72c62 WIP: Adding deprecation notice to DIN1505-2 saying it has been superseded by ISO 690 (JabRef#4454)
1928c2b Fix links after KI update
fad65b7 Turn Kidney International into AMA dependent
6357af5 Update association-for-computing-machinery.csl (JabRef#4459)
eab02ea Create berlin-school-of-economics-and-law-international-marketing-man… (JabRef#3774)
a3e3d97 One more metadata fix
e7d5071 Some Sheldon metadata fixes
3ad4260 Create jurnal-sains-farmasi-dan-klinis.csl (JabRef#4455)
46370dc Add "AIMS Press" journals (JabRef#4458)
57fca07 Update association-for-computing-machinery.csl (JabRef#4456)
6fa90ed Add "Muséum national d'Histoire naturelle" journal styles (JabRef#4457)
7faf0b0 Bundle update
e3c1f85 Create cryptogamie, bryologie (JabRef#4350)
525bba5 Create iso690-full-note-cs.csl (JabRef#4414)
932fad5 Create iso690-author-date-de.csl (JabRef#4344)
ab23108 Create mbts-fullnote-bibliography.csl (JabRef#4363)
c163008 Create associacao-brasileira-de-normas-tecnicas-ibict-full.csl (JabRef#4202)
5586bbc Create associacao-brasileira-de-normas-tecnicas-ibict-initials.csl (JabRef#4203)
483efcb Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-service-engineering.csl (JabRef#4442)
92f437d Create independent style for molecular-nutrition-and-food-research.csl… (JabRef#4342)
0d7f481 Update taylor-and-francis-council-of-science-editors-author-date.csl (JabRef#4385)
2b2786b Create ritid-timarit-hugvisindastofnunnar.csl (JabRef#4315)
9534999 Create jsbm.csl (JabRef#4371)
b390657 Changed term on access macro, added rules for bill (JabRef#4407)
95c24f9 Create ecausp-abnt.csl (JabRef#4420)
66ca962 Reindent/reorder
91fefee Create materials-express.csl (JabRef#4445)
ea5d50b Create institut-catholique-de-paris.csl (JabRef#4450)
a4c07e2 Create institut-catholique-de-paris.csl (JabRef#4374)
8a17ae0 Update canadian-geotechnical-journal.csl (JabRef#4447)
7165db0 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4448)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: e2416fa
github-actions bot pushed a commit to ddunig2/jabref that referenced this issue Feb 6, 2020
e106215 Create annales-de-demographie-historique.csl (JabRef#4512)
4dd974e Create lauterbornia.csl (JabRef#4525)
e5277ae Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4551)
f9cfe40 Add new IOP dependents (JabRef#4549)
daff985 Create brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4544)
10c6fa8 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4545)
c531528 create mcgill9-en.csl, Canadian McGill legal style (JabRef#4532)
e2416fa Update clinical-and-experimental-optometry.csl (JabRef#4538)
e71363e Create geriatrie-et-psychologie-neuropsychiatrie-du-vieillissement.csl (JabRef#4543)
cdd973e APA: Add "personal communication" localization (JabRef#4539)
77bdb6f Create eksploatacja-i-niezawodnosc (JabRef#4531)
7858966 Ready: Update psychological-medicine.csl (JabRef#4536)
264141a Create south-african-actuarial-journal.csl (JabRef#4534)
1fde301 Create pakistan-journal-of-agricultural-sciences.csl (JabRef#4535)
3020eb3 Update hochschule-fur-soziale-arbeit-fhnw.csl (JabRef#4533)
57c8122 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4530)
17c178f Update zeitschrift-fur-internationale-beziehungen.csl (JabRef#4527)
14cf589 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4528)
ca60d6e Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4524)
74c5ae9 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4526)
999e124 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4521)
caabe36 Fix psychiatric services
f50e6f0 Add files via upload (JabRef#4519)
c728658 Create harvard-lancaster-university.csl (JabRef#4520)
11e9ac9 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4511)
101b81c Update agriculturae-conspectus-scientificus.csl (JabRef#4510)
615377e Create international-journal-of-population-data-science.csl (JabRef#4517)
fe7cb69 Update university-of-york-apa.csl
f0c7374 Fix AGLC Subsequents
6a8ec90 More Uni Gottingen fixes
9c0f5c6 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4460)
22ef83d Update Universitatsmedizin Gottingen
d2f90c9 Create drying-technology.csl (JabRef#4515)
01e339b Create terrorism-and-political-violence.csl (JabRef#4514)
6414c15 Create international-journal-of-hyperthermia.csl (JabRef#4513)
f80b38c Create Sciences Po - Ecole doctorale (note, French) (JabRef#4486)
6a22929 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4508)
19c89f5 Create citation-compass-apa-note.csl (JabRef#4500)
fe72590 Chicago fixes & add no-ibid variant (JabRef#4503)
d602477 Update agriculturae-conspectus-scientificus.csl (JabRef#4505)
8a8911b Create mediterranean-journal-of-chemistry.csl (JabRef#4506)
ce77b28 Create conservation-and-society.csl (JabRef#4507)
25a5092 Add IMS journals (JabRef#4496)
a39430e Create rmit-university-harvard.csl (JabRef#4504)
830aa7b Update john-benjamins-publishing-company-collective-volumes.csl (JabRef#4444)
43e9216 Create PHBern IVP (JabRef#4427)
a052fd6 Create Publications du Groupe d'anthropologie et d'archéologie funéra… (JabRef#4499)
a7e12e1 Further improve legal cites for BJPS (JabRef#4497)
744a507 Update agriculturae-conspectus-scientificus.csl (JabRef#4498)
bfffaed APA: Fix sort order for in-text citations (JabRef#4495)
c48d08b Add "Blood Cancer Discovery" for AACR (JabRef#4492)
f628cb2 Medizinische Fakultät Mannheim - Numerisch (JabRef#4490)
77876a4 Improve legal cites for british-journal-of-political-science (JabRef#4488)
3c0c4ee Create apa-with-abstract.csl (JabRef#4487)
a26fa95 Update afte-journal.csl (JabRef#4489)
a7bf678 Create agriculturae-conspectus-scientificus.csl (JabRef#4491)
bb01625 Make ET&C dependent of CSE (JabRef#4483)
b4418ef Create ahmad-ibrahim-kulliyyah-of-laws-international-islamic-universi… (JabRef#4482)
22872d2 APA: Use "et al." in Dutch (JabRef#4484)
5f6c080 Update weed-research.csl (JabRef#4485)
b2fbe15 APA 7th edition (JabRef#4419)
c236ade Create BFCN.csl (JabRef#4481)
25d40cd Update iso690-full-note-cs.csl (JabRef#4480)
5de3904 Update budownictwo-i-architektura-pl.csl (JabRef#4479)
9d9c1da Add files via upload (JabRef#4478)
96200b0 Create instituto-alberto-luiz-coimbra-de-pos-graduacao-e-pesquisa-de-… (JabRef#4476)
8aa9cb0 Update APA journal styles (JabRef#4475)
8549afa Update in-text citation for legal_case for BJPS (JabRef#4470)
71c9e4d Update surgical-neurology-international.csl (JabRef#4472)
a9dac17 Create FUNDING.yml
633e864 Create helsingin-yliopisto-teologinen-tiedekunta-teologian-tyyli.csl (JabRef#4303)
8797c01 Create romanian-iso-690-full-note-with-ibid-romanian.csl (JabRef#4465)
c1519e1 Create assosiation-of-firearms-and-toolmark-examiners.csl (JabRef#4468)
c974e30 Update ieee.csl (JabRef#4467)
a1b7386 Update stale.yml (JabRef#4466)
db549dd Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (JabRef#4462)
2822437 Update .travis.yml (JabRef#4463)
3d72c62 WIP: Adding deprecation notice to DIN1505-2 saying it has been superseded by ISO 690 (JabRef#4454)
1928c2b Fix links after KI update
fad65b7 Turn Kidney International into AMA dependent
6357af5 Update association-for-computing-machinery.csl (JabRef#4459)
eab02ea Create berlin-school-of-economics-and-law-international-marketing-man… (JabRef#3774)
a3e3d97 One more metadata fix
e7d5071 Some Sheldon metadata fixes
3ad4260 Create jurnal-sains-farmasi-dan-klinis.csl (JabRef#4455)
46370dc Add "AIMS Press" journals (JabRef#4458)
57fca07 Update association-for-computing-machinery.csl (JabRef#4456)
6fa90ed Add "Muséum national d'Histoire naturelle" journal styles (JabRef#4457)
7faf0b0 Bundle update
e3c1f85 Create cryptogamie, bryologie (JabRef#4350)
525bba5 Create iso690-full-note-cs.csl (JabRef#4414)
932fad5 Create iso690-author-date-de.csl (JabRef#4344)
ab23108 Create mbts-fullnote-bibliography.csl (JabRef#4363)
c163008 Create associacao-brasileira-de-normas-tecnicas-ibict-full.csl (JabRef#4202)
5586bbc Create associacao-brasileira-de-normas-tecnicas-ibict-initials.csl (JabRef#4203)
483efcb Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-service-engineering.csl (JabRef#4442)
92f437d Create independent style for molecular-nutrition-and-food-research.csl… (JabRef#4342)
0d7f481 Update taylor-and-francis-council-of-science-editors-author-date.csl (JabRef#4385)
2b2786b Create ritid-timarit-hugvisindastofnunnar.csl (JabRef#4315)
9534999 Create jsbm.csl (JabRef#4371)
b390657 Changed term on access macro, added rules for bill (JabRef#4407)
95c24f9 Create ecausp-abnt.csl (JabRef#4420)
66ca962 Reindent/reorder
91fefee Create materials-express.csl (JabRef#4445)
ea5d50b Create institut-catholique-de-paris.csl (JabRef#4450)
a4c07e2 Create institut-catholique-de-paris.csl (JabRef#4374)
8a17ae0 Update canadian-geotechnical-journal.csl (JabRef#4447)
7165db0 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4448)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: e106215
@tb77phd
Copy link
Author

tb77phd commented Sep 2, 2020

An update to this two years old issue;

I have recently come back to JabRef and this issue still persisted in 5.1. Since I had over a 1000 files that were unlinked, I decided to revert to an old version to try things.

Recap of issue: I use the Regular Expression **/.*[title].*\\.[extension] to link files. In the versions since September 2018, JabRef could not find files that contained non-alphabetical (and non-numerical? not sure...) characters in the title. See examples above. Even a simple dash could not be handled.

I removed 5.1 and found and installed JabRef version 3.6.

Marking all of my over 2000 entries and hitting F7 (Automatically set file links), it worked like a charm! Suddenly, my list of over a 1000 unlinked files was down to less than 200! The remaining unlinked files were easily fixed (e.g., title has a colon but filename has a semicolon since Windows don't allow colons in filenames, or filename was truncated due to a very long title, stuff like that).

I don't know what changed between version 3.6 and (presumably) version 4.x to hinder a regular expression search containing non-alphabetical characters in the title (it didn't have an issue with such characters in the bibtexkey then but I didn't test it now).

Now that my entire library is linked, I'll happily come back to the latest version 5.2.

I'll change the title of this issue to a better description.

@tb77phd tb77phd changed the title Link files Finding files with non-alphabetical characters in title Sep 2, 2020
@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Sep 2, 2020
@koppor
Copy link
Member

koppor commented Sep 2, 2020

May I ask whether there is test data for this somewhere?

  • .bib file
  • .pdf files with the filenames

Maybe, three BibTeX entries and three unlinked files.

@tb77phd
Copy link
Author

tb77phd commented Sep 3, 2020

bib_pdfs.zip
I hope uploading a ZIP with PDFs and a .bib file works.

One of the files (YOUNG ea ...) has numbers in the title. I tried F7 with it and it worked, so numbers should not be an issue.

@Siedlerchr
Copy link
Member

@tb77phd I could reproduce the issue and it seems it's done on purpose. The "dash" character, addtional whitespace and other unwanted latex chars

/**
* Removes any '-', unnecessary whitespace and latex commands formatting
*/
private static String formatTitle(String title) {

@Siedlerchr Siedlerchr added status: waiting-for-feedback The submitter or other users need to provide more information about the issue and removed good first issue An issue intended for project-newcomers. Varies in difficulty. labels Dec 10, 2020
@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

k3KAW8Pnf7mkmdSMPHz27 commented Dec 29, 2020

Is the issue that the title is needed unchanged? As @Siedlerchr says, [title] makes modifications to the title, [TITLE] should not, so perhaps that works? (note that it does not "resolve" latex)

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

Actually, would [TITLE:latex_to_unicode:regex(":",";")] work?

@tb77phd
Copy link
Author

tb77phd commented Jan 11, 2021

Huh, I was not aware of a difference between [title] and [TITLE]. I tried right now and it worked when the issue was a dash in the filename. It did not work when the issue was parentheses. Thanks for the suggestion!

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

k3KAW8Pnf7mkmdSMPHz27 commented Jan 12, 2021

🤦 that does make sense, I missed that. If I am not mistaken, the expanded bracket will be interpreted as regexp, so parenthesis will be seen as a regexp matching groups and probably you won't get any result at all if they are unmatched.

In your current version you might be able to solve it using either "\\Q...\\E" or "\Q...\E" (match the content between literally instead of as a regexp), e.g., \\Q[TITLE:latex_to_unicode:regex(":",";")]\\E, see https://docs.oracle.com/en/java/javase/14/docs/api/java.base/java/util/regex/Pattern.html#quote for more details. Even if this workaround works (which I am not completely sure of), I believe this must be changed in the code.
You can escape parenthesises and brackets ()[] using the :regex("","") modifier, but I would not recommend it as it'll stop working as soon as this is fixed (a couple of days).

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

Huh, I was not aware of a difference between [title] and [TITLE]

I am not sure if it was supposed to be a difference, but it is. And I am trying to make it official by sneakily making people use it 🤫

@koppor
Copy link
Member

koppor commented Jan 18, 2021

Huh, I was not aware of a difference between [title] and [TITLE]
I am not sure if it was supposed to be a difference, but it is.

This is NOT in our documentation. See https://docs.jabref.org/setup/citationkeypatterns.

A field marker generally consists of the field name enclosed in square braces, e.g., [title]

I know at https://docs.jabref.org/setup/citationkeypatterns#bibentry-fields, we use upper case letters. IMHO this is wrong. It should be [title], [date] there, too.

The implementation having a difference between title and TITLE comes from following feature:

https://docs.jabref.org/setup/citationkeypatterns#title-related-field-markers

[title]: Capitalize all the significant words of the title, and concatenate them. For example, An awesome paper on JabRef becomes AnAwesomePaperonJabref
[fulltitle]: The title with unchanged capitalization.

This was introduced before #3670. Via #3238, I could track some hint at b1a9593.

To satisfy the old behaviour without breaking the makeLabel code, it was
necessary to introduce the '[fulltitle]' field, which leaves the title
unchanged, and to change the test for '[title]' expansion, which now
removes hyphens ("-").

I could not find the original commit.

Nevertheless, this behavior is really odd.

I see a mixture of "special" field names, which should not appear in normal BibTeX. However, authors is very close to author in BibTeX.

Solution options

Option A: Maybe, we should convert all field markers to modifiers. We can keep the "old" behavior for compatibility reasons.

Option B: In case we do not want to change the whole behavior, we should solve the "overlapping" behavior at title/TITLE. We should rename title to sigtitle ("significant title"), use the current title magic.

Option C: In addition to Option B, we should remove all non-signifcant words. IMHO AnAwesomePaperonJabRef is wrong, because the capital letters do not help here.

Side notes

  • At Directory pattern bracketed expressions #3238 one sees our "old" file format pattern, before we decided to use the (easier) BibTeX key patterns for filenames, too.
  • It is not clear to me whether our documentation is wrong, I think "For an entry with the title An awesome paper on JabRef, the citation key pattern Title[title:abbr] will provide the key TitleAAPoJ." is wrong, it is [TITLE:abbr], isn't it?

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

k3KAW8Pnf7mkmdSMPHz27 commented Jan 19, 2021

I know at https://docs.jabref.org/setup/citationkeypatterns#bibentry-fields, we use upper case letters. IMHO this is wrong. It should be [title], [date] there, too.

Imo, the motivation for keeping the difference between title and TITLE is that a user doesn't necessarily expect, nor can deal with, a raw bibentry field. _I_ have tripped on the difference between [authors] and [author], and given how much time I have spent in that part of the source code, that is saying something. [authors] vs [AUTHOR] on the other hand.

  • It is not clear to me whether our documentation is wrong, I think "For an entry with the title An awesome paper on JabRef, the citation key pattern Title[title:abbr] will provide the key TitleAAPoJ." is wrong, it is [TITLE:abbr], isn't it?
  • Title[title:abbr] -> TitleAAPoJ
  • Title[TITLE:abbr] -> TitleAapoJ (raw field, capitalization is kept)

I could not find the original commit.

I believe it is #2610

@koppor
Copy link
Member

koppor commented Jan 19, 2021

Summary: Documentation is wrong. Only upper case field names are used to access the fields of the Bibentry directly. Thus, I updated the documentation accordingly:

grafik

Long answer:

I know at docs.jabref.org/setup/citationkeypatterns#bibentry-fields, we use upper case letters. IMHO this is wrong. It should be [title], [date] there, too.
Imo, the motivation for keeping the difference between title and TITLE is that a user doesn't necessarily expect, nor can deal with, a raw bibentry field. I have tripped on the difference between [authors] and [author], and given how much time I have spent in that part of the source code, that is saying something. [authors] vs [AUTHOR] on the other hand.

Thefore, I raised Option A in my last comment, which I would prefer for strong typing. (This probably also raised #2610 (comment)).

grafik

The case sensitivity of the field name drives me mad somehow. - Sinse I don't see another solution and I think, the lower case fields are used more often then the plain ones, it is OK to go ahead.

Question: I can also use [year] as there is a fallback on the Bibentry plain fields, isn't it?

I believe it is #2610

Yeah, that's it.

With my doc update, the related issue koppor#237 can be closed.

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

k3KAW8Pnf7mkmdSMPHz27 commented Jan 20, 2021

Question: I can also use [year] as there is a fallback on the Bibentry plain fields, isn't it?

Yes. The "special field markers" are matched case-sensitive, while "bibentry plain fields" are matched case-insensitive. What you are seeing with upper case fields is the fallback, because it does not match a “special field marker” (yes, it is ugly).

Only upper case field names are used to access the fields of the Bibentry directly. Thus, I updated the documentation accordingly:

My bad, and thank you for the update. I guess I wanted to keep the original vocabulary that a "special field marker" is a "field marker" even if it is not a bibentry field, just based on a bibentry field.

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

k3KAW8Pnf7mkmdSMPHz27 commented Jan 20, 2021

Thefore, I raised Option A in my last comment, which I would prefer for strong typing. (This probably also raised #2610 (comment)).

I don't understand "Option A". Do I interpret you correctly as in that all "special field markers" should be (re)implemented as a "field marker" followed by modifiers?


Huh, I was not aware of a difference between [title] and [TITLE]

I am not sure if it was supposed to be a difference, but it is. And I am trying to make it official by sneakily making people use it 🤫

Imho opinion, the current behavior isn't great, but I can't think of a better one. JabRef's purpose, in my opinion, is to hide the ugly truth of BibTeX/biblatex/latex from their users. Auto-generated filenames should be using latex-free Unicode whenever it is possible, and if the user doesn't want that, they should be able to access the text-fields themselves and do whatever they want with them. Therefore I view all lower-case field markers as "nicely behaved ones" and upper-case ones as "don't use unless you have to".

Long term, I'd like to break the behavior of [title], and replace it with [TITLE:latex_to_unicode:title_case] when it is used for file names. This will break the behavior of almost all the current bracketed patterns (because they don't resolve latex). I just haven't had time to submit any PR regarding this because my priorities regarding JabRef contributions are,

  1. Overleaf
  2. Update Groups for JavaFX
  3. Update BracketedPattern

@koppor
Copy link
Member

koppor commented Jan 24, 2021

Thefore, I raised Option A in my last comment, which I would prefer for strong typing. (This probably also raised #2610 (comment)).
I don't understand "Option A". Do I interpret you correctly as in that all "special field markers" should be (re)implemented as a "field marker" followed by modifiers?

That's what I meant.

Imho opinion, the current behavior isn't great, but I can't think of a better one. JabRef's purpose, in my opinion, is to hide the ugly truth of BibTeX/biblatex/latex from their users. Auto-generated filenames should be using latex-free Unicode whenever it is possible, and if the user doesn't want that, they should be able to access the text-fields themselves and do whatever they want with them. Therefore I view all lower-case field markers as "nicely behaved ones" and upper-case ones as "don't use unless you have to".

We should put your text in the documentation 👍. I could only write it shorter (but deleted it after reading your text).

Long term, I'd like to break the behavior of [title], and replace it with [TITLE:latex_to_unicode:title_case] when it is used for file names.

Random thoughts on that: Maybe, it will difficult to maintain if it behaves differently than when used at BibTeX keys. However, I think, it is good that BibTeX keys are not automatically Unicode. Because of bibtex. Maybe, the user has to do use :unicode_to_latex somehow... This somehow refs: #160

All in all: Go ahead :)

Nevertheless, I would like to discuss title vs. camel with you. As programmer, I find it strange that "filler words" are just appended. In case they would be deleted, that would make sence. But just appended. Why not removing it at [title]? 😇

1. Overleaf

This is nearly done. I was nearly finishing it. Please investigate koppor#445. The main think, I was working on, is this comment: #2866 (comment). - We can surely have a chat on that (gitter, skype, ..., ?)

@Siedlerchr
Copy link
Member

Count me in for sharelatex,/overleaf I can help as well. I wrote most of the code back int the days.

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

Regarding the bracketed patterns/citationkeys etc., my take-away is that when I can find the time for it (not anytime soon), I'll open up a PR expanding on what I think is reasonable, why, and what I'd like to do about it. I don't think there's much more to say that does not lead to needless details that might suit better in the context of an actual PR.

Nevertheless, I would like to discuss title vs. camel with you. As programmer, I find it strange that "filler words" are just appended. In case they would be deleted, that would make sence. But just appended. Why not removing it at [title]? 😇

I am not sure of what you are referring to. I believe both [title] and [camel] only remove things. Could you give an example or context?

We should put your text in the documentation 👍. I could only write it shorter (but deleted it after reading your text).

Regarding default/ADVANCED field usage? In my opinion, shorter text tend to be better. 😛

@koppor
Copy link
Member

koppor commented Jan 25, 2021

Nevertheless, I would like to discuss title vs. camel with you. As programmer, I find it strange that "filler words" are just appended. In case they would be deleted, that would make sence. But just appended. Why not removing it at [title]? 😇
I am not sure of what you are referring to. I believe both [title] and [camel] only remove things. Could you give an example or context?

Sure. Do you know the term paperon?

[camel]: Capitalize and concatenate all the words of the title. For example, An awesome paper on JabRef becomes AnAwesomePaperOnJabref
[title]: Capitalize all the significant words of the title, and concatenate them. For example, An awesome paper on JabRef becomes AnAwesomePaperonJabref

I find AnAwesomePaperOnJabref much more readble. For me, AwesomePaperJabref would also be OK. But not AnAwesomePaperonJabref. What is Paperon for a word?

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

k3KAW8Pnf7mkmdSMPHz27 commented Jan 26, 2021

What is Paperon for a word?

Fair enough. We can look at this now or when/if I get time to address the bracketed pattern class. I don't really have a preference regarding it 😛

For me, AwesomePaperJabref would also be OK

Perhaps one could change the documentation/default to use [shorttitle] for citation keys? Perhaps implement [shorttitleN] where N is the number of words, and the default is 3 to maintain compatibility with the current use?

Nevertheless, I would like to discuss title vs. camel with you.

I am not very well versed on camel case/proper case/title case and their ilks. I think in this instance "proper case" would make us both happy-ish.
It would become An Awesome Paper On Jabref when used to generate a file name, and since all spaces are removed for citation keys, it would automatically be converted to camel case.
The issue would be honoring protective brackets, {JabRef}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external files status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants