Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identifier paste should work with Unicode REPLACEMENT CHARACTER #11986

Open
koppor opened this issue Oct 16, 2024 · 2 comments · May be fixed by #12083
Open

Identifier paste should work with Unicode REPLACEMENT CHARACTER #11986

koppor opened this issue Oct 16, 2024 · 2 comments · May be fixed by #12083
Assignees
@MadDingzhen
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@koppor
Copy link
Member

koppor commented Oct 16, 2024

Clicking on the quick import with a "strange" DOI, JabRef does not find anythign.

Image

To repdoce:

  1. Open test PDF src/test/resources/pdfs/test-doi.pdf in Acrobat Reader (not SumatraPDF)
  2. Select the DOI https://doi.org/10.1007/978-3-662-65004-2_3 including the end of line (put the mouse to the next line to include the line break)
  3. Copy the selected text
  4. Go to JabRef
  5. Click the button "Import by ID"
  6. Paste
  7. Click on the button to import the ID.
  8. See that nothing is imorted.

The method to fix is org.jabref.model.entry.identifier.DOI#findInText.

Add test to org.jabref.model.entry.identifier.DOITest#testData. I assume duplicating a test case and adding Unicode replacement character should be a good start for test-driven development.
@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Oct 16, 2024
@MadDingzhen
Copy link

Hi! May I work on this issue? I'm new here, thank you!

@koppor koppor added FirstTimeCodeContribution Triggers GitHub Greeter Workflow 📍 Assigned Assigned by assign-issue-action (or manually assigned) labels Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

⚠ Note that this issue will become unassigned if it isn't closed within 30 days.

🔧 A maintainer can also add the Pinned label to prevent it from being unassigned automatically.

Happy coding! 🚀

MadDingzhen added a commit to MadDingzhen/jabref that referenced this issue Oct 25, 2024
@MadDingzhen
Solved "Identifier paste should work with Unicode REPLACEMENT CHARACTER
89a3e57 
JabRef#11986"
This was referenced Oct 25, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MadDingzhen MadDingzhen

Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Good First Issues
Status: Assigned
Milestone
No milestone
2 participants
@koppor @MadDingzhen