Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught exception when closing a library that does not exists #10948

Closed
2 tasks done
martinctl opened this issue Feb 29, 2024 · 5 comments · Fixed by #10950
Closed
2 tasks done

Uncaught exception when closing a library that does not exists #10948

martinctl opened this issue Feb 29, 2024 · 5 comments · Fixed by #10950
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs FirstTimeCodeContribution Triggers GitHub Greeter Workflow ui

Comments

@martinctl
Copy link
Contributor

martinctl commented Feb 29, 2024

JabRef version

5.12 (latest release)

Operating system

macOS

Details on version and operating system

Sonoma 14.2.1

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Open JabRef
  2. Do not create or open a library
  3. Press cmd + w (ctrl + w) or File -> Close library
Screenshot 2024-02-29 at 11 45 44

Appendix

Screenshot 2024-02-29 at 11 46 00
Log File
ERROR: Uncaught exception occurred in Thread[#29,JavaFX Application Thread,5,system]: java.lang.NullPointerException: Cannot invoke "org.jabref.gui.LibraryTab.requestClose()" because "libraryTab" is null
@Siedlerchr
Copy link
Member

Can you please try the latest development version? If I remember correctly this should be fixed already
You can use the https://builds.jabref.org/main/ arm64 version

@koppor
Copy link
Member

koppor commented Feb 29, 2024

Related #4795 (dplicate of #4665)

@koppor koppor added the ui label Feb 29, 2024
@martinctl
Copy link
Contributor Author

I have tested the latest development version on mac and Windows 11 and it does not seems to be fixed

@martinctl
Copy link
Contributor Author

Also I would like to be assigned to this issue if you think it's fine for a first time code contribution

@koppor koppor added ui and removed ui labels Feb 29, 2024
@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs FirstTimeCodeContribution Triggers GitHub Greeter Workflow labels Feb 29, 2024
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

martinctl added a commit to martinctl/jabref that referenced this issue Feb 29, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 3, 2024
…10950)

* fix: check that the current tab is not null before closing it

* fix: add stateManager to the CloseDatabaseAction command to disable it when unusable (#10948)

* feat: update CHANGELOG.md

* fix: move check on null to CloseDatabaseAction#execute

* Removed superfluous new line

---------

Co-authored-by: Carl Christian Snethlage <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs FirstTimeCodeContribution Triggers GitHub Greeter Workflow ui
Projects
Development

Successfully merging a pull request may close this issue.

3 participants