Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scholar.archive.org as fetcher #10498

Closed
Siedlerchr opened this issue Oct 16, 2023 · 3 comments · Fixed by #10549
Closed

Add scholar.archive.org as fetcher #10498

Siedlerchr opened this issue Oct 16, 2023 · 3 comments · Fixed by #10549
Assignees
Labels
fetcher FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@Siedlerchr
Copy link
Member

Is your suggestion for improvement related to a problem? Please describe.
I want to search scholar.archive.org from JabRef

Describe the solution you'd like
A new fetcher in JabRef

Additional context
They offer an API
https://scholar.archive.org/api/redoc

@Siedlerchr Siedlerchr added fetcher good first issue An issue intended for project-newcomers. Varies in difficulty. labels Oct 16, 2023
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Oct 16, 2023
@liyou969
Copy link
Contributor

Hi, I am really interested in this problem. Could you assign it to me? Thank you

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 16, 2023
@github-actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Oct 16, 2023
@Siedlerchr
Copy link
Member Author

Implementation details:
Take a look at the existing Fetchers.
This fetcher should be implementing the PagedSearchBasedParserFetcher interface as it has parameters for getting "pages (offset + limit)

The returned bib entry should contain the fields that are present in the biblio json key:
Additionally, abstract should be inlude as well

contrib_names can be mapped to author.

   "biblio": {
        "affiliations": [],
        "container_ident": "iedolmzeofgc3ezyedga7h4eba",
        "container_issnl": "1050-2947",
        "container_name": "Physical Review A. Atomic, Molecular, and Optical Physics",
        "contrib_count": 1,
        "contrib_names": [
          "Andrew P. Hines",
          "P. C. E. Stamp"
        ],
        "doi": "10.1103/physreva.75.062321",
        "doi_prefix": "10.1103",
        "doi_registrar": "crossref",
        "issns": [
          "1050-2947",
          "1094-1622"
        ],
        "issue": "6",
        "issue_int": 6,
        "lang_code": "en",
        "publisher": "American Physical Society (APS)",
        "publisher_type": "society",
        "release_date": "2007-06-19",
        "release_ident": "ahxlekfzf5h53ku7houbphbfny",
        "release_stage": "published",
        "release_type": "article-journal",
        "release_year": 2007,
        "title": "Quantum walks, quantum gates, and quantum computers",
        "volume": "75",
        "volume_int": 75
      },

Example most simple query:
curl -s -H "Accept: application/json" "https://scholar.archive.org/search?q=quantum"

Bonus; Implement the FullTextFetcher interface as well.
One can use the DOI to search as well.
If the result contains a fulltext pdf
e.g. curl -s -H "Accept: application/json" "https://scholar.archive.org/search?q=doi:10.1136/GUT.52.12.1678"

github-merge-queue bot pushed a commit that referenced this issue Nov 6, 2023
* Create Fetcher and Transformer for ScholarArchive

* Finish change requirement including code style, testing, some error , and comment.

* Finish and fix archive scholar fetcher

* add url

* fix arch

* fix test

* fix var name

* remove comments

* add changelog

* fuck this changelog

---------

Co-authored-by: youliyou <[email protected]>
Co-authored-by: Siedlerchr <[email protected]>
@github-project-automation github-project-automation bot moved this from Reserved to Done in Good First Issues Nov 6, 2023
Siedlerchr added a commit to lisongxuan/jabref that referenced this issue Nov 9, 2023
…Selected

* upstream/main:
  Update to JavaFX 21.01 (JabRef#10627)
  Fix JabRef#10498 Create Fetcher and Transformer for ScholarArchive (JabRef#10549)
  fix tests
  Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625)
  Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1
  Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2
  Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0
  Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0
  Change linter (JabRef#10614)
Siedlerchr added a commit to xuanan20020/jabref that referenced this issue Nov 10, 2023
* upstream/main: (24 commits)
  Add support for scite.ai (JabRef#10617)
  Update tests.yml (JabRef#10631)
  replace "SearchAll" in web search by "Search Selected" (JabRef#10611)
  Use System preference for light dark theme (JabRef#10593)
  Fix NPE in lookup identifer
  Add minimum requirements to CHANGELOG.md (JabRef#10628)
  Update to JavaFX 21.01 (JabRef#10627)
  Fix JabRef#10498 Create Fetcher and Transformer for ScholarArchive (JabRef#10549)
  fix tests
  Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625)
  Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1
  Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2
  Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0
  Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0
  Change linter (JabRef#10614)
  change codecov (JabRef#10616)
  Add entry based on ISSN number JabRef#10124 (JabRef#10178)
  Enable journal information fetcher directly in popup (JabRef#10598)
  Make generate button wider (JabRef#10588)
  make openRewrite stable again
  ...

# Conflicts:
#	CHANGELOG.md
#	src/main/resources/l10n/JabRef_en.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetcher FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants