Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arxiv and eprinttype #10474

Closed
thecaligarmo opened this issue Oct 10, 2023 · 8 comments · Fixed by #10491
Closed

arxiv and eprinttype #10474

thecaligarmo opened this issue Oct 10, 2023 · 8 comments · Fixed by #10491
Assignees
Labels
fetcher FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement

Comments

@thecaligarmo
Copy link

Is your suggestion for improvement related to a problem? Please describe.
When you import from arxiv (Using "New Entry" -> ID type = Arxiv -> Arxiv id) everything works magically =D But, there's a tiny thing that could be better. Right now, when you import it does not create a "eprinttype = {arxiv}" part in bibtex. What this means is that when you then try and access the url link for "eprint", it fails because it doesn't have eprinttype set.

Describe the solution you'd like
When creating a new entry, if the new entry is an arxiv entry, then set the eprinttype to "arxiv"

@Siedlerchr Siedlerchr added type: enhancement good first issue An issue intended for project-newcomers. Varies in difficulty. labels Oct 10, 2023
@GuSheldom
Copy link
Contributor

Hi, I would like to work on this issue, would you mind assign it to me, please? Thanks!

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 10, 2023
@github-actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@GuSheldom
Copy link
Contributor

Hi, I find a bug but I cannot explain why, when I try to import a entry with arxiv ID, it will return me 'archiveprefix = {arXiv}', which should be 'eprinttype = {arXiv}' if it is correct.
image

However, when I debugging the code, I find the ArXivFetcher should run correct,
image

Is that caused by the 'ArXivIdentifier' which return me the wrong identifier, or other reason, that change the eprinttype to archiveprefix?

@GuSheldom
Copy link
Contributor

Or it is caused by the EntryConverter

@Siedlerchr
Copy link
Member

Maybe in the post cleanup actions?

@GuSheldom
Copy link
Contributor

I have fix the issue, but I think it is not an enhancement but a bug

@ThiloteE
Copy link
Member

Sometimes fixing a bug is like adding a feature and sometimes introducing a feature is like adding a bug. ;-)

github-merge-queue bot pushed a commit that referenced this issue Oct 19, 2023
* add the archivePrefix when parsing the eprint, the bibtex format will read the archivePrefix rather than eprinttype.

* modify the change request

* Small refactor

* add FIXED message to CHANGELOG.md

---------

Co-authored-by: Gu Xiuchen <[email protected]>
Co-authored-by: HoussemNasri <[email protected]>
@Siedlerchr
Copy link
Member

@thecaligarmo Thanks to @GuSheldom this issue is now fixed in the latest developer version:

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/main and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetcher FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants