Minor code improvements in library properties dialog (#9265)

Mainly changing an observable list to an ordinary readonly list, which is sufficient and slightly more performant.
JabRef · Oct 20, 2022 · eee8322 · eee8322
1 parent b969f6f
commit eee8322
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/src/main/java/org/jabref/gui/libraryproperties/LibraryPropertiesViewModel.java b/src/main/java/org/jabref/gui/libraryproperties/LibraryPropertiesViewModel.java
@@ -1,8 +1,6 @@
 package org.jabref.gui.libraryproperties;
 
-import javafx.beans.property.ReadOnlyListWrapper;
-import javafx.collections.FXCollections;
-import javafx.collections.ObservableList;
+import java.util.List;
 
 import org.jabref.gui.libraryproperties.constants.ConstantsPropertiesView;
 import org.jabref.gui.libraryproperties.general.GeneralPropertiesView;
@@ -12,10 +10,10 @@
 
 public class LibraryPropertiesViewModel {
 
-    private final ObservableList<PropertiesTab> propertiesTabs;
+    private final List<PropertiesTab> propertiesTabs;
 
     public LibraryPropertiesViewModel(BibDatabaseContext databaseContext) {
-        propertiesTabs = FXCollections.observableArrayList(
+        propertiesTabs = List.of(
                 new GeneralPropertiesView(databaseContext),
                 new SavingPropertiesView(databaseContext),
                 new ConstantsPropertiesView(databaseContext),
@@ -35,7 +33,7 @@ public void storeAllSettings() {
         }
     }
 
-    public ObservableList<PropertiesTab> getPropertiesTabs() {
-        return new ReadOnlyListWrapper<>(propertiesTabs);
+    public List<PropertiesTab> getPropertiesTabs() {
+        return propertiesTabs;
     }
 }
diff --git a/src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesView.java b/src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesView.java
@@ -10,7 +10,6 @@
 import javafx.scene.control.TextField;
 
 import org.jabref.gui.libraryproperties.AbstractPropertiesTabView;
-import org.jabref.gui.libraryproperties.PropertiesTab;
 import org.jabref.gui.util.ViewModelListCellFactory;
 import org.jabref.logic.l10n.Localization;
 import org.jabref.model.database.BibDatabaseContext;
@@ -20,7 +19,7 @@
 import com.airhacks.afterburner.views.ViewLoader;
 import jakarta.inject.Inject;
 
-public class GeneralPropertiesView extends AbstractPropertiesTabView<GeneralPropertiesViewModel> implements PropertiesTab {
+public class GeneralPropertiesView extends AbstractPropertiesTabView<GeneralPropertiesViewModel> {
     @FXML private ComboBox<Charset> encoding;
     @FXML private ComboBox<BibDatabaseMode> databaseMode;
     @FXML private TextField generalFileDirectory;