Merge remote-tracking branch 'upstream/master' into allowReordering

* upstream/master: (166 commits)
  New Crowdin translations (#6382)
  Update code-howtos.md (#6393)
  Fix jstyle was invalid with default section at the start (#6386)
  Correcting file name for groups.uml (#6373)
  Fix underscore character being omitted from file name in Recent Libraries list (#6389)
  Rework journal abbreviation caching (#6304)
  Fix selecting custom export for copy to clipboard with uppercase file ext (#6290)
  New Crowdin translations (#6375)
  Squashed 'src/main/resources/csl-styles/' changes from 143464e..906cd6d
  Fixes #6357: File directory (#6377)
  Disable the generate button if the ID field is empty (#6371)
  Fix Preferences style value too long (#6372)
  Fix various Dark theme issues (#6368)
  Correct label name in dependabot
  Bump java-diff-utils from 4.5 to 4.7 (#6365)
  Try with info.plist.template also (#6366)
  Fix wrong button order (Apply and Cancel) in ManageProtectedTermsDialog. (#6358)
  Bump flexmark-ext-gfm-strikethrough from 0.61.6 to 0.61.20 (#6361)
  Bump checkstyle from 8.31 to 8.32 (#6360)
  Bump flexmark-ext-gfm-tasklist from 0.61.16 to 0.61.20 (#6364)
  ...

.dependabot/config.yml

@@ -6,7 +6,7 @@ update_configs:
     directory: "/"
     update_schedule: "weekly"
     default_labels:
-      - "dependencies"
+      - "type: dependencies"
     automerged_updates:
       - match:
          dependency_type: "all"

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,19 +1,18 @@
 <!-- 
 Describe the changes you have made here: what, why, ... 
-Link issues by using the following pattern: #333.
-If you fixed a koppor issue, link it with following pattern: [koppor#47](https://github.com/koppor/jabref/issues/47).
+Link issues that are fixed, e.g. "Fixes #333".
+If you fixed a koppor issue, link it, e.g. "Fixes https://github.com/koppor/jabref/issues/47".
 The title of the PR must not reference an issue, because GitHub does not support autolinking there.
 -->
 
 
 <!-- 
-- All items with `[ ]` are still a TODO.
-- All items checked with `[x]` are done.
-- Remove items not applicable
+- Go through the list below. If a task has been completed, mark it done by using `[x]`.
+- Please don't remove any items, just leave them unchecked if they are not applicable.
 -->
 
 - [ ] Change in CHANGELOG.md described (if applicable)
 - [ ] Tests created for changes (if applicable)
 - [ ] Manually tested changed features in running JabRef (always required)
-- [ ] Screenshots added in PR description (for bigger UI changes)
-- [ ] [Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not: Issue created at <https://github.com/JabRef/user-documentation/issues>.
+- [ ] Screenshots added in PR description (for UI changes)
+- [ ] [Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not created an issue at <https://github.com/JabRef/user-documentation/issues> or, even better, submitted a pull request to the documentation repository.

.github/outdatedDependencies.md

@@ -1,5 +1,5 @@
 ---
 title: Outdated dependencies
-labels: code-quality, dependencies
+labels: t: dependencies
 ---
 [There are outdated dependencies!](https://github.com/JabRef/jabref/actions?query=is%3Afailure+workflow%3A%22Check+dependencies%22) 

.github/workflows/cleanup_pr.yml

@@ -29,7 +29,7 @@ jobs:
         if: ${{ steps.checksecrets.outputs.secretspresent }}
         uses: appleboy/[email protected]
         with:
-          script: rm -rf /var/www/builds.jabref.org/www/${{ steps.extract_branch.outputs.branch }}
+          script: rm -rf /var/www/builds.jabref.org/www/${{ steps.extract_branch.outputs.branch }} || true
           host: build-upload.jabref.org
           port: 9922
           username: jrrsync

.github/workflows/deployment.yml

@@ -25,15 +25,15 @@ jobs:
       matrix:
         os: [ubuntu-latest, windows-latest, macOS-latest]
         include:
-         - os: ubuntu-latest
-           displayName: linux
-           archivePortable: tar -c -C build/distribution JabRef | pigz --rsyncable > build/distribution/JabRef-portable_linux.tar.gz && rm -R build/distribution/JabRef
-         - os: windows-latest
-           displayName: windows
-           archivePortable: 7z a -r build/distribution/JabRef-portable_windows.zip ./build/distribution/JabRef && rm -R build/distribution/JabRef
-         - os: macOS-latest
-           displayName: macOS
-           archivePortable: brew install pigz && tar -c -C build/distribution JabRef.app | pigz --rsyncable > build/distribution/JabRef-portable_macos.tar.gz && rm -R build/distribution/JabRef.app
+          - os: ubuntu-latest
+            displayName: linux
+            archivePortable: tar -c -C build/distribution JabRef | pigz --rsyncable > build/distribution/JabRef-portable_linux.tar.gz && rm -R build/distribution/JabRef
+          - os: windows-latest
+            displayName: windows
+            archivePortable: 7z a -r build/distribution/JabRef-portable_windows.zip ./build/distribution/JabRef && rm -R build/distribution/JabRef
+          - os: macOS-latest
+            displayName: macOS
+            archivePortable: brew install pigz && tar -c -C build/distribution JabRef.app | pigz --rsyncable > build/distribution/JabRef-portable_macos.tar.gz && rm -R build/distribution/JabRef.app
 
     runs-on: ${{ matrix.os }}
     name: Create installer and portable version for ${{ matrix.displayName }}
@@ -44,35 +44,20 @@ jobs:
       - name: Fetch all history for all tags and branches
         run: git fetch --prune --unshallow
       - name: Install GitVersion
-        uses: gittools/actions/gitversion/[email protected].1
+        uses: gittools/actions/gitversion/[email protected].2
         with:
-          versionSpec: '5.1.3'
+          versionSpec: '5.2.x'
       - name: Run GitVersion
         id: gitversion
-        uses: gittools/actions/gitversion/[email protected].1
+        uses: gittools/actions/gitversion/[email protected].2
       - name: Set up JDK
         uses: actions/setup-java@v1
         with:
           java-version: 14
-      # configuration based on https://github.com/actions/cache/blob/master/examples.md#java---gradle
-      - uses: actions/cache@v1
-        name: Restore gradle cache
-        with:
-          path: ~/.gradle/caches
-          key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
-          restore-keys: |
-            ${{ runner.OS }}-gradle-${{ env.cache-name }}-
-            ${{ runner.OS }}-gradle-
-            ${{ runner.OS }}-
-      - uses: actions/cache@v1
-        name: Cache gradle wrapper
-        with:
-          path: ~/.gradle/wrapper
-          key: ${{ runner.os }}-gradle-${{ hashFiles('gradle/wrapper/gradle-wrapper.properties') }}
       - name: Build runtime image
         run: ./gradlew -PprojVersion="${{ steps.gitversion.outputs.AssemblySemVer }}" -PprojVersionInfo="${{ steps.gitversion.outputs.InformationalVersion }}" jlinkZip
       - name: Build installer
-        run: ./gradlew -PprojVersion="${{ steps.gitversion.outputs.AssemblySemVer }}" -PprojVersionInfo="${{ steps.gitversion.outputs.InformationalVersion }}" jpackage
+        run: ./gradlew -i -PprojVersion="${{ steps.gitversion.outputs.AssemblySemVer }}" -PprojVersionInfo="${{ steps.gitversion.outputs.InformationalVersion }}" jpackage
         shell: bash
       - name: Package application image
         run: ${{ matrix.archivePortable }}
@@ -109,12 +94,12 @@ jobs:
       - name: Fetch all history for all tags and branches
         run: git fetch --prune --unshallow
       - name: Install GitVersion
-        uses: gittools/actions/gitversion/[email protected].1
+        uses: gittools/actions/gitversion/[email protected].2
         with:
-          versionSpec: '5.1.3'
+          versionSpec: '5.2.x'
       - name: Run GitVersion
         id: gitversion
-        uses: gittools/actions/gitversion/[email protected].1
+        uses: gittools/actions/gitversion/[email protected].2
       - name: Get linux binaries
         uses: actions/download-artifact@master
         with:

.github/workflows/snap.yml

@@ -1,6 +1,9 @@
 name: Snap
 
 on:
+  push:
+    branches:
+      - snapcraft
   schedule:
     # run on each day
     - cron: '33 4 * * *'

.github/workflows/stale.yml

@@ -0,0 +1,18 @@
+name: Mark stale issues and pull requests
+
+on:
+  schedule:
+  - cron: "0 0 * * *"
+
+jobs:
+  stale:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/stale@master
+      with:
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
+        stale-issue-message: 'This issue will be closed in 7 days due to inactivity :zzz: Please provide the requested information if the problem persists.'
+        stale-issue-label: 'status: stale'
+        days-before-stale: 30
+        only-labels: 'status: waiting-for-customer-feedback'

.github/workflows/tests.yml

@@ -205,7 +205,7 @@ jobs:
         if: ${{ steps.checksecrets.outputs.secretspresent }}
         run: xvfb-run --auto-servernum ./gradlew jacocoTestReport && bash <(curl -s https://codecov.io/bash);
         env:
-          CI: "false" # we pretend to run locally - even if tests fail on the CI, they count towards test coverage
+          CI: "true"
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
           DBMS: "postgresql"
   # This is https://github.com/marketplace/actions/gradle-wrapper-validation

.gitignore

@@ -50,6 +50,8 @@ gradle.properties
 jabref.xml
 *.sonargraph
 
+## !! IN CASE YOU UPDATE, PLEASE KEEP THE LINES AT THE END OF THE FILE !!
+
 
 # Created by https://www.gitignore.io/api/gradle,java,jabref,intellij,eclipse,netbeans,windows,linux,macos,node,snapcraft
 # Edit at https://www.gitignore.io/?templates=gradle,java,jabref,intellij,eclipse,netbeans,windows,linux,macos,node,snapcraft
@@ -370,8 +372,16 @@ typings/
 # nuxt.js build output
 .nuxt
 
-# react / gatsby 
-public/
+# rollup.js default build output
+
+# Uncomment the public line if your project uses Gatsby
+# https://nextjs.org/blog/next-9-1#public-directory-support
+# https://create-react-app.dev/docs/using-the-public-folder/#docsNav
+# public
+
+# Storybook build outputs
+.out
+.storybook-out
 
 # vuepress build output
 .vuepress/dist
@@ -385,6 +395,9 @@ public/
 # DynamoDB Local files
 .dynamodb/
 
+# Temporary folders
+temp/
+
 ### Snapcraft ###
 /parts/
 /stage/
@@ -444,15 +457,17 @@ gradle-app.setting
 
 # End of https://www.gitignore.io/api/gradle,java,jabref,intellij,eclipse,netbeans,windows,linux,macos,node,snapcraft
 
--# we really version .jar files - needs to be go after the www.gitignore.io-generated ones, because they ignore *.jar files
--!/lib/*.jar
--
--# do not distribute Oracle's JDBC driver
--lib/ojdbc.jar
--
--# do not ignore the source of the build
--!/buildSrc/src/
--!/buildSrc/src/main/groovy/org/jabref/build
--
--# do not ignore JabRef icons (they are ignored by the macos setting above)
--!src/main/java/org/jabref/gui/icon
+## !! KEEP THESE LINES !!
+
+# we really version .jar files - needs to be go after the www.gitignore.io-generated ones, because they ignore *.jar files
+!/lib/*.jar
+
+# do not distribute Oracle's JDBC driver
+lib/ojdbc.jar
+
+# do not ignore the source of the build
+!/buildSrc/src/
+!/buildSrc/src/main/groovy/org/jabref/build
+
+# do not ignore JabRef icons (they are ignored by the macos setting above)
+!src/main/java/org/jabref/gui/icon

.mailmap

@@ -188,3 +188,8 @@ Victor Michelan <[email protected]>
 P4trice <[email protected]>
 Julien Bénard <[email protected]>
 Alexsandro Lauber <[email protected]>
+Alexander Girgis <[email protected]>
+Christoph Treude <[email protected]>
+Goutam Lavudiya <[email protected]>
+Shikun Xiong <[email protected]>
+Fabiani Giovanni <[email protected]>